Your message dated Thu, 21 Mar 2019 00:50:38 +0000
with message-id <e1h6luo-0008zc...@fasolo.debian.org>
and subject line Bug#924291: fixed in netrek-client-cow 3.3.1-2
has caused the Debian Bug report #924291,
regarding netrek-client-cow: build can loop indefinitely on failure
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
924291: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924291
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: netrek-client-cow
Version: 3.3.1-1
Severity: serious
Justification: breaks build infrastructure
When mkkey fails to run, netrek-client-cow has a very bad failure mode.
It loops until mkkey succeeds:
| until ./mkkey key.cow.linux "Client Of Win" "automatic packaged key"
"qu...@us.netrek.org" "netrek.org/files/COW/" "inl,standard2"; do sleep 1; done
When mkkey fails reliably and produces output, this causes the build to
run indefinitely as sbuild only abort a build that has no output for a
prologned time. This behaviour can make buildds and QA infrastructure
hang.
I suggest using a bounded loop and failing hard after a number of
attempts. That's a very simple solution to the problem at hand. For
instance:
| attempts=32; until ./mkkey ...; do attempts=$((attempts - 1)); test $attempts
-le 0 && exit 1; sleep 1; done
Furthermore I question why a key should be created at build time and
then be distributed to consumers of the package. That seems to run
counter to the concept of a "key". If the key is to protect anything, it
must not be public. Maybe the best course of action would be not
creating this key at all during build.
Helmut
--- End Message ---
--- Begin Message ---
Source: netrek-client-cow
Source-Version: 3.3.1-2
We believe that the bug you reported is fixed in the latest version of
netrek-client-cow, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 924...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Markus Koschany <a...@debian.org> (supplier of updated netrek-client-cow
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 20 Mar 2019 21:31:57 +0100
Source: netrek-client-cow
Architecture: source
Version: 3.3.1-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-de...@lists.alioth.debian.org>
Changed-By: Markus Koschany <a...@debian.org>
Closes: 924291
Changes:
netrek-client-cow (3.3.1-2) unstable; urgency=medium
.
* Team upload.
* Fix possible infinite loop. (Closes: #924291)
* Move the package to salsa.debian.org.
Checksums-Sha1:
8340e4036998c3c3a35eee94837d050cde1c8af5 2244 netrek-client-cow_3.3.1-2.dsc
b68b6c0421a50911e0707621b3f97ce8d2c18fea 7076
netrek-client-cow_3.3.1-2.debian.tar.xz
3a1533e687f3bffc40e02b2596fa7100e5e2a01e 11613
netrek-client-cow_3.3.1-2_amd64.buildinfo
Checksums-Sha256:
10da3134d9d48d43c4a2bc6e6adc71e531594dd569740b96498077921bb55df5 2244
netrek-client-cow_3.3.1-2.dsc
57d273ba54b6e69f6dd438b100a3c06200301010015d834b772f9a75909e78fd 7076
netrek-client-cow_3.3.1-2.debian.tar.xz
8b902688ca12292d3e23ed282727548039ef3239a2b9901fdc20bcdae5b9cc1d 11613
netrek-client-cow_3.3.1-2_amd64.buildinfo
Files:
c5e6a7ebf87b30fb876a981f741f969c 2244 games optional
netrek-client-cow_3.3.1-2.dsc
fa123d743932fdc64bfb481c40924ade 7076 games optional
netrek-client-cow_3.3.1-2.debian.tar.xz
d4e901bd7fd92e2f828304c4e98ccb9e 11613 games optional
netrek-client-cow_3.3.1-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQKjBAEBCgCNFiEErPPQiO8y7e9qGoNf2a0UuVE7UeQFAlyS141fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEFD
RjNEMDg4RUYzMkVERUY2QTFBODM1RkQ5QUQxNEI5NTEzQjUxRTQPHGFwb0BkZWJp
YW4ub3JnAAoJENmtFLlRO1HkbpQQAMzNPIcST5Zlfov9hLmPzYPdnnfuwMg7gIvK
Lz1LHGjqn7UlrFenX7w9WBChO+YyFERO/NEknmQOfWZpFfLX49GDrBS5Xi6/HdCN
wTN8R+ykrtxslTpDiJuqgdxudLlPtDJBWpAWpnfwyMdZQH5ws7BcUJz44eQmR9dm
0nAHoa+7SNTzdXenR9A1huDIyZ5jdSPeQPpf25fIW1eC786tDTyZEPyTPTb0ab3E
6CBdeoRHecT3uyJJdzxR2gKIegj6lqg0FtjVO/m1h2m+zFM+OHijxkzq2xT9QQ4Z
PGs6nzGOF3MzCYww02KTtuqPUniVhs4/ruxjVaQOJqbxOIPSKDLWrQRGqKW2trCL
uKjFEGMa7LvxIUhEtRMyxusS7HDuOIVBe94Cv/8q5ILCC8uL9I3ZHIJfJGTkwg+/
8xsnLFQ3EQ4vqtilyv79iVtLJmWs/7FaVyg+1aIq4YHreOYChzKstZvA+6/HegBm
AINDTujySAU2HspG8mtgvNNtfcLH45fNIfmwQ+Z2E7wR5HzzKncg7+tgOCLw36RI
g81gDQN/tgijEssjfF52SJwbHKwQOiW0jX5eQsXqMDRu/uhd5wfSV6/wW5n7q/sc
/Og2CmsLb1fx5Fk3p3vm0dEGjhcZR6JWwAc4Vk6gD1na7Fc9cEN204hzs4UYq3g8
7yo665KK
=FyRY
-----END PGP SIGNATURE-----
--- End Message ---
