control: tags -1 +confirmed

[2019-07-17 07:41] Helmut Grohne <hel...@subdivi.de>
> part       text/plain                1094
> Control: reopen -1
> Control: affects -1 + src:dropbear
>
> On Tue, Jul 16, 2019 at 08:42:09PM +0000, Debian Bug Tracking System wrote:
> >    * dh_installinit: Fix regression where dh_installinit bailed
> >      out on --name if only one of the acted on packages had an
> >      init script file.  Thanks to Helmut Grohne for reporting
> >      the issue.  (Closes: #932073)
>
> The bug is partially fixed. A full build of openssh and dropbear now
> works. At least the following situation (dropbar) is still broken:
>
> The init script lives in an arch-all package, you pass the relevant
> --name and you perform an arch-only build. Here is a cross build log,
> but it fully reproduces natively:

Yep, -A/-B separation. Can someone remind me its purpose?

As for code, then instead of "$dh{DOPACKAGES}" there must be
"getpackages()", like this. Not sure how to write regression test for
this situation.

diff --git a/dh_installinit b/dh_installinit
index 5aecf25b..6a7abaf8 100755
--- a/dh_installinit
+++ b/dh_installinit
@@ -233,7 +233,7 @@ init(options => {
 my %snippet_options = ('snippet-order' => 'service');
 
 if (my $name = $dh{NAME}) {
-       if (!grep { -f "debian/$_.${name}.init" || -f 
"debian/$_.${name}.default" } @{$dh{DOPACKAGES}}) {
+       if (!grep { -f "debian/$_.${name}.init" || -f 
"debian/$_.${name}.default" } getpackages()) {
                error("--name=$dh{NAME} option specified, but init script nor 
default file not found");
        }
 }

-- 
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.

Reply via email to