Hi!
On Sat, 2019-07-27 at 12:20:00 -0300, intrigeri wrote:
> gregor herrmann:
> > In dpt-new-upstream we're using Dpkg::Changelog::Debian from
> > libdpkg-perl, which might help here as well.
> Oh, this is very interesting, thanks! I had taken a look at that
> module, but from the documentation I understood it only gives us "the
> number of changelog entries that have been parsed with success", so
> I had discarded this option.
If the documantion was not clear, I'd be happy to try to improve it so
that other people do not get this impression too. Could you cover a bit
what lead you to that conclusion?
> I'm very glad I was mislead. It looks like Dpkg::Changelog{,::*} are
> sufficient for many, if not most, use cases of Parse::DebianChangelog :)
> We might have to check what API is public and supported, and improve
> the documentation accordingly: for example, the "load" method that
> our new-upstream script uses does not seem to be documented anywhere.
Right (see my other mail), given that it's a direct successor, it
should cover almost everything, except for example the output formats
that got axed.
Hmm about the load() method, it seems I removed that because this
class does not implement the parse() method which load() requires,
when trying to clarify and document all the inherited methods in
commit 853f59ec0468f72fa29811a8fe48fad91fab6083. Thanks, will fix! :)
BTW, currently the preferred way to parse a changelog file is IMO to
use Dpkg::Changelog::Parse, as that will make sure to handle possible
custom formatters. I'm not entirely happy with this interface, because
it seems obviously less discoverable than just creating a new
Dpkg::Changelog (or Dpkg::Changelog::Debian), but merging it into the
base class' new() does not seem right either, but maybe as another
constructor method… :)
Thanks,
Guillem
