Your message dated Mon, 21 Oct 2019 06:19:14 +0000
with message-id <e1imr2a-000cwf...@fasolo.debian.org>
and subject line Bug#942757: fixed in odb-api 0.18.1-8
has caused the Debian Bug report #942757,
regarding odb-api: fails to build with multiple supported python3 versions
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
942757: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=942757
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: odb-api
Version: 0.18.1-7
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)

Dear Maintainer,

odb-api fails to build when multpile python3 versions are supported, as
is the case in Ubuntu Focal currently, like this:

for f in `py3versions --supported | sed -e 's%python3.7%%'  ` ; do \
        /usr/bin/make -C /<<PKGBUILDDIR>>/debian/build/$f 
DESTDIR=/<<PKGBUILDDIR>>/debian/tmp ; \
        done
make[2]: Entering directory '/<<PKGBUILDDIR>>'
make[2]: *** /<<PKGBUILDDIR>>/debian/build/python3.8: No such file or 
directory.  Stop.
make[2]: Leaving directory '/<<PKGBUILDDIR>>'

(full log here:
https://launchpadlibrarian.net/447773633/buildlog_ubuntu-focal-amd64.odb-api_0.18.1-7build1_BUILDING.txt.gz)

It seems to me that the code that runs to configure the package for
other python versions is just wrong: it uses $$d in the argument to
--builddirectory which is not defined anywhere, it passed
--builddirectory to dh_auto_configure after "--" (so it is passed to the
upstream configure script, not dh) and it sets the build directory to be
a subdirectory of the "default" build directory. I don't know if this
last point is an actual problem (although it does smell funny to me),
but this patch fixes this anyway, as well as the other two problems.

Cheers,
mwh
-- System Information:
Debian Release: buster/sid
  APT prefers eoan
  APT policy: (500, 'eoan'), (400, 'eoan-proposed')
Architecture: amd64 (x86_64)

Kernel: Linux 5.3.0-18-generic (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru odb-api-0.18.1/debian/rules odb-api-0.18.1/debian/rules
--- odb-api-0.18.1/debian/rules 2019-09-02 04:48:13.000000000 +1200
+++ odb-api-0.18.1/debian/rules 2019-10-21 14:17:49.000000000 +1300
@@ -55,14 +55,14 @@
        done
        dh_auto_configure --  ${CMAKE_CFLAGS} 
-DPYTHON_EXECUTABLE=/usr/bin/${PY3DEFAULT}
        for f in ${PY3OTHERS} ; do \
-               dh_auto_configure --  ${CMAKE_CFLAGS} 
-DPYTHON_EXECUTABLE=/usr/bin/$$f \
-                        --builddirectory=$(BUILDDIR)/$$d ; \
+               dh_auto_configure --builddirectory=$(BUILDDIR)-$$f \
+                         -- ${CMAKE_CFLAGS} -DPYTHON_EXECUTABLE=/usr/bin/$$f; \
                done
 
 override_dh_auto_build:
        $(MAKE) -C $(BUILDDIR) DESTDIR=$(DESTDIR)
        for f in ${PY3OTHERS} ; do \
-               $(MAKE) -C $(BUILDDIR)/$$f DESTDIR=$(DESTDIR) ; \
+               $(MAKE) -C $(BUILDDIR)-$$f DESTDIR=$(DESTDIR) ; \
                done
 
 override_dh_auto_test:

--- End Message ---
--- Begin Message ---
Source: odb-api
Source-Version: 0.18.1-8

We believe that the bug you reported is fixed in the latest version of
odb-api, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 942...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Alastair McKinstry <mckins...@debian.org> (supplier of updated odb-api package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 20 Oct 2019 20:57:26 +0100
Source: odb-api
Architecture: source
Version: 0.18.1-8
Distribution: unstable
Urgency: medium
Maintainer: Alastair McKinstry <mckins...@debian.org>
Changed-By: Alastair McKinstry <mckins...@debian.org>
Closes: 942757 3942687
Changes:
 odb-api (0.18.1-8) unstable; urgency=medium
 .
   * Drop Fortran-Mod: no longer used by dh_fortran_mod
   * Standards-Version: 4.4.1.0; no changes required
   * Patch for eckit 1.4.2 changes (+ compiler update?)
   * Split eckit; now provided in separate package
   * Typo in d/rules blocks python3.8 build. Closes: #942757, 3942687
Checksums-Sha1:
 cd6c5dc8e467e581bd3218e1593d9263d44cc680 2565 odb-api_0.18.1-8.dsc
 68f3864dd5ec14fedb6ddac6dd32ca87ecf20bfd 26832 odb-api_0.18.1-8.debian.tar.xz
Checksums-Sha256:
 88a6654935bc33bcb46eeafc1d73359111479d4ed4fbb231502ec4b5ec654d27 2565 
odb-api_0.18.1-8.dsc
 e67ef693a75ecb5a866622904381a2bb6fa10369dd49f608c9b5584faf6eaf24 26832 
odb-api_0.18.1-8.debian.tar.xz
Files:
 e9c19645bca035684ad72d02a9d284d5 2565 utils optional odb-api_0.18.1-8.dsc
 d4f2e81eb808f9edcc8b87a2ea1c8d2b 26832 utils optional 
odb-api_0.18.1-8.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEgjg86RZbNHx4cIGiy+a7Tl2a06UFAl2tSXIACgkQy+a7Tl2a
06VgChAAjwMHs+I4bQ9z7nhlxPDH2wDyqopWcbmbPhEKqz4dwgi+jdZE4l2zIVZ2
7znbNHnLiRP0Egt8NS6gOZwL0+6+HlDOT/4DviBkKoONf2i1cf3rpN8nry+B9kmk
gRpv+GpCwMDLQdKFE0JSCO/nTSyS11xEY4KxIIC0UWsZsTIZzBSKMvt8oUP8o1WH
VW6/nXpKrxP0ajVLQkEnxwrQXibkMCtrNanv3eutanCLagjYXkmdw8EXSpKN+SxX
B2hPibYMFiEcwRqS/hdCMDDSkGAxHNcsXeXYeAIvlobf0EMP2UH4+gpgpJE+ehhx
LkSYOiMWiSEi/YokuLzTSTxmTK9Hs8cTwYjNIFXlD7Ceh+XNY7Oymgvi9lwJjk5o
Uu9606oL+FxKBW0VSQCDlitd5tHe3Bm5R5ZICriQWryIu8cYpSwWURYvZ6ejtvHh
/Sh74bXv1UGgMytlrVSqhTnzFf+ykawSCRFw6pxnVR54JFjB4la9jbzeC8ECmsdg
YedxtV2gWyaRYFs6Z23HyVh4hkoeluMUSat4WpjySsxngZxin9vCURLKGvtdLvKy
BAAyrV1ylun+9r138+ZhkQ4mT6m1D3wU+/R7SwPAQAAfgfFprDtqyAGqyXKaQhPH
OfuZ3KCwI9unzI+hw4oI7dTU/BEvXoBwyGWu36+pQwKNJLTSmXY=
=BgAT
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to