Your message dated Mon, 18 Nov 2019 07:05:26 +0000 with message-id <e1iwb6e-00052e...@fasolo.debian.org> and subject line Bug#944572: fixed in simka 1.5.1-2 has caused the Debian Bug report #944572, regarding simka: debian/rules does not trap for errors to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 944572: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944572 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: src:simka Version: 1.5.1-1 Severity: serious Tags: patch Dear maintainer: The debian/rules file for this package has a "for" which does not always trap errors if they happen. To see why this is a problem, compare the following two Makefile snippets: for command in false true; do $${command}; done echo MARK for command in true false; do $${command}; done echo MARK The first one will succeed, the second one will not, but in fact none of them should really succeed. The simple patch below should fix this. Please see Debian Policy 4.6. "Error trapping in makefiles" for a more complete explanation: https://www.debian.org/doc/debian-policy/ch-source.html#error-trapping-in-makefiles Thanks. --- a/debian/rules +++ b/debian/rules @@ -15,7 +15,7 @@ override_dh_install: rm -r debian/tmp/usr/example \ debian/tmp/usr/scripts chrpath --delete debian/simka/usr/bin/* - for file in debian/simkamin/usr/share/simkamin/*.py; do mv "$$file" "$${file%%.py}"; done + set -e; for file in debian/simkamin/usr/share/simkamin/*.py; do mv "$$file" "$${file%%.py}"; done mv debian/simkamin/usr/share/simkamin/simkaMin_utils debian/simkamin/usr/share/simkamin/simkaMin_utils.py override_dh_fixperms:
--- End Message ---
--- Begin Message ---Source: simka Source-Version: 1.5.1-2 We believe that the bug you reported is fixed in the latest version of simka, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 944...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Shayan Doust <he...@shayandoust.me> (supplier of updated simka package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 18 Nov 2019 07:05:39 +0100 Source: simka Binary: simka simkamin Architecture: source Version: 1.5.1-2 Distribution: unstable Urgency: medium Maintainer: Debian Med Packaging Team <debian-med-packag...@lists.alioth.debian.org> Changed-By: Shayan Doust <he...@shayandoust.me> Description: simka - comparative metagenomics method dedicated to NGS datasets simkamin - approximate comparative metagenomics method dedicated to NGS data Closes: 944572 Changes: simka (1.5.1-2) unstable; urgency=medium . [ Steffen Moeller ] * d/u/metadata: yamllint * Update metadata with ref to conda . [ Shayan Doust ] * Fix debian/rules not trapping for errors (Closes: #944572) * Specify architectures that can build this package * More verbose output and slight change to simkamin.install . [ Andreas Tille ] * Standards-Version: 4.4.1 * Remove trailing whitespace in debian/rules * Set upstream metadata fields: Repository. Checksums-Sha1: 1ff27e97964ecaaff512ab44ef1cc2f85189fb67 2191 simka_1.5.1-2.dsc 3157592ef3db566354f1e37f9a2d019f1d026d34 20580 simka_1.5.1-2.debian.tar.xz Checksums-Sha256: a64b14ea7b40d6a5c16bc1b120a1a06b5060bdb42f84eaca0c492e482b62db2f 2191 simka_1.5.1-2.dsc 59c00483c1772e134535d371c85b88e074307c5768912c8074cd974630eae4ca 20580 simka_1.5.1-2.debian.tar.xz Files: c0cb963d78fdae54178bda183de8c179 2191 science optional simka_1.5.1-2.dsc ffa8cfa42c80ec14a689fcab8f6260b6 20580 science optional simka_1.5.1-2.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQJCBAEBCAAsFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAl3SPfgOHHRpbGxlYUBy a2kuZGUACgkQV4oElNHGRtHZMw//bilvC4hKdGew9crx3W0Nnb+AIoUg94iApFIl psLRqNEm9MMonNd4CSFd54ARg6Kho92US15X20BgCv99leH3WZmcWM4gvm8UK09m L2WmN5Q2W+BY13+gVbKQ5Uc9TQmA7ycmBPrbT7R/tbUgm5vLg1IyBmTLuvH6S0CW Nd8WQRY2S9Fg5mhEuQfvWsYUNNv21u7a0P4bSQ5aQiuqbluDRuYE3C79Y4q3zoSr M8gNyJ6jKmX0+4Oj2JEEMAQwtxFFSybvbJtxq1Nb3eWvW4I5rZ4YyYyQAUYsYjVg 4v+IsXBiKKJ5cMWvvpCaPekFxLCqV0j2LV+uGgPpkfCfErztH0yMoj5wsHnqvoKj vYY/g3UNgI6KuWxqJIAPvEqEf5iVD96nBLiDS1NkmuZfkCi/i7+OhwglvTrWWLQZ ahB77hkcf2As7VMKvhjypENmJdGmhuPlZLDdw4+e5W9Rx7OiheiojShXWk/Zhkkl XgcEy3U1qo7H8tO30obnFfQ1BAZguraeTnYHIWeFweWdLdvNUE5iH08j5MpnpZpo MKtOkyRADzpGB8K4E+eFqbL+L/iGSQjNVzktW8z6h+F6BieaRKihOJXM7SH124tX HDiiM6liHBtDlupLRe6oDKT0rFVGl2Jrdf8rHkUd+o1plXw805R9eweqFZgSO8MB hN4zJ64= =j8bR -----END PGP SIGNATURE-----
--- End Message ---
