Package: python-incremental
Version: 16.10.1-3
Severity: serious
Tags: bullseye, sid, patch

python-incremental recommends, the incremental source package build-depends on 
and the incremental autopkgtests depend on python-click. Python-click in turn 
depends on the python-colorama binary package, which is no longer built by the 
python-colorama source package. It is still present in testing as a cruft 
package, but is completely gone from unstable.

The long-term solution to this would be to drop python2 support, however I do 
not think that is practical at this time. In particular python-twisted depends 
on python-incremental and the python-twisted python 2 removal bug still has a 
whole bunch of blockers.

From grepping the code it looks like python-incremental only uses python-click 
for the update script, not for the run-time stuff. So I have prepared a patch 
that eliminates them. This also involved disabling the testsuite/autopkgtest 
for python 2 (but keeping it enabled for python 3).

A debdiff is attached, if I get no objections I will probablly NMU this later.


diff -Nru incremental-16.10.1/debian/changelog 
incremental-16.10.1/debian/changelog
--- incremental-16.10.1/debian/changelog        2016-11-03 20:27:56.000000000 
+0000
+++ incremental-16.10.1/debian/changelog        2019-12-27 12:48:06.000000000 
+0000
@@ -1,3 +1,14 @@
+incremental (16.10.1-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove build-depends and reccomends on python-click (Closes: ??????)
+  * Disable python 2 autopkgtests and remove associated test dependencies.
+  * Disable testsuite for python 2 (keep it enabled for python 3)
+  * Add note to package description about incremental.update functionality
+    and python-click.
+
+ -- Peter Michael Green <plugw...@debian.org>  Fri, 27 Dec 2019 12:48:06 +0000
+
 incremental (16.10.1-3) unstable; urgency=medium
 
   * Recommend python Twisted and Click, in order to use incremental.update
diff -Nru incremental-16.10.1/debian/control incremental-16.10.1/debian/control
--- incremental-16.10.1/debian/control  2016-11-03 20:27:56.000000000 +0000
+++ incremental-16.10.1/debian/control  2019-12-27 12:48:06.000000000 +0000
@@ -7,7 +7,6 @@
                python-all (>= 2.6.6-3),
                python-setuptools (>= 0.6b3),
                python-twisted-core,
-               python-click,
                python3-all,
                python3-setuptools (>= 0.6b3),
                python3-twisted,
@@ -20,12 +19,16 @@
 Package: python-incremental
 Architecture: all
 Depends: ${misc:Depends}, ${python:Depends}
-Recommends: python-click, python-twisted-core
+Recommends: python-twisted-core
 Provides: ${python:Provides}
 Description: Library for versioning Python projects.
  Incremental is a small library that versions your Python projects.
  .
  This package provides the Python 2.x module.
+ .
+ The incremental.update functionality requires the click module which is
+ no longer available for python 2 in Debian. If you require this functionality
+ we suggest using python 3.
 
 Package: python3-incremental
 Architecture: all
diff -Nru incremental-16.10.1/debian/rules incremental-16.10.1/debian/rules
--- incremental-16.10.1/debian/rules    2016-11-03 17:40:25.000000000 +0000
+++ incremental-16.10.1/debian/rules    2019-12-27 12:48:06.000000000 +0000
@@ -2,6 +2,10 @@
 
 export PYBUILD_NAME=incremental
 
+# Don't test python 2 because python-click is not available anymore.
+export PYBUILD_DISABLE_python2=test
+export PYBUILD_DISABLE_python2-dbg=test
+
 # XXX Unit tests seem to leave cruft around, for some reason
 export PYBUILD_AFTER_TEST=rm -rf {build_dir}/incremental.tests.*
 
diff -Nru incremental-16.10.1/debian/tests/control 
incremental-16.10.1/debian/tests/control
--- incremental-16.10.1/debian/tests/control    2016-11-03 20:27:56.000000000 
+0000
+++ incremental-16.10.1/debian/tests/control    2019-12-27 12:47:49.000000000 
+0000
@@ -1,7 +1,5 @@
-Tests: unit-tests-2 unit-tests-3
+Tests: unit-tests-3
 Restrictions: needs-root
 Depends: @,
-         python-twisted-core,
-         python-click,
          python3-twisted,
          python3-click

Reply via email to