On Fri, 17 Apr 2020 at 08:09, Andreas Tille <andr...@an3as.eu> wrote:
> Hi Matthew, > > On Fri, Apr 17, 2020 at 07:40:54AM -0700, Matthew Fernandez wrote: > > > > As a jumping off point, the attached patch fixes some issues with > logging calls in the upstream 1.2.4 source release. > > Thanks for the patch which I applied to packaging Git. I assume you > want to express that while these fixes are definitely good coding > practice the bus error problem is not fixed by it, right? Thanks, Andreas. It may fix the bus error, but I don’t have a MIPS machine to test on. Some of those logging calls had the potential to leave you with a misaligned stack pointer. IIUC unaligned loads on MIPS could cause such a bus error.