On 11/21/20 5:40 AM, Elliott Mitchell wrote: > On Fri, Nov 20, 2020 at 08:02:26PM +0100, Hans van Kranenburg wrote: >> So, >> >> On 9/21/20 4:16 PM, Hans van Kranenburg wrote: >>> [...] >>> >>> gcc -Wl,-z,relro -Wl,-z,now -pthread -Wl,-soname >>> -Wl,libxentoolcore.so.1 -shared -Wl,--version-script=libxentoolcore.map >>> -o libxentoolcore.so.1.0 handlereg.opic >>> /usr/bin/ld: i386:x86-64 architecture of input file `handlereg.opic' is >>> incompatible with i386 output >>> /usr/bin/ld: handlereg.opic: file class ELFCLASS64 incompatible with >>> ELFCLASS32 >>> /usr/bin/ld: final link failed: file in wrong format >>> collect2: error: ld returned 1 exit status >> >> This one is caused by "debian/rules: Combine shared Make args". I >> reverted that change for now. >> >> [...] > > I was going to type, "That can't be true! Both sections are identical, > so that commit *couldn't* have done it!" > > Being the careful sort, look closer. Look closer. Then realize if one > reads fast they look identical, but they're getting *slightly* different > values for ${XEN_TARGET_ARCH}. Mainly for $(make_args_xen), > ${XEN_TARGET_ARCH} gets $(xen_arch_$(flavour)), but for > $(make_args_tools), ${XEN_TARGET_ARCH} gets $(xen_arch_$(DEB_HOST_ARCH)). > > Three of us and we didn't spot that difference. Should still combine > ${XEN_COMPILE_ARCH} which remains identical for both values.
Ok, I will make it a partial revert and add the above information about it. Thanks. Hans