On 2020-12-15 5:04 p.m., Trek wrote: > On Tue, 15 Dec 2020 12:45:40 -0400 > Jesse Smith <jsm...@resonatingmedia.com> wrote: > >> I gave the patch a test run and, while I like what it does in theory, >> in practise I'm running into trouble with it. When I use the attached >> patch and then run "make check" in the insserv source directory, >> inssrev segfaults after about eight tests. I haven't had a chance yet >> to hunt down what is causing the problem, but I'm guessing a variable >> is getting used before it is given a value/initialized. > well, moving the Start_Stop_Overlap call broke the assumption that > start_levels and stop_levels are never undefined, so this additional > patch should fix the regression > > make check now passes all 240 tests > > thanks for the review and happy hacking! :)
Thank you for the updated patch. I have confirmed it works here and passes all checks. I've committed the change for the upcoming 1.23.0 branch of insserv. People are welcome to test it out and, when the next version gets published, this fix (and update to the manual page) will be included. - Jesse
