Hello Colin Watson, On Sun, Feb 14, 2021 at 01:05:11PM +0000, Colin Watson wrote: > Thanks for digging into this. > > How about this approach instead? Given the choice between a > packaging-only change and one that requires another patch against > upstream, I have a slight preference for the packaging-only change as > long as it's basically reasonable, which I think this is. It just > overrides configure's automatic detection and tells it that sha2.h isn't > available. Builds cleanly and doesn't seem to incur any new direct > dependencies.
Whatever works and feel free to choose the way you as maintainer prefers as far as I'm concerned! :) FWIW I make similar choices myself, but my definition of preferred solution is a bit more complicated. Nothing is ever as permanent as something temporary. It's not uncommon to see a temporary hack be forgotten about and then not be dropped when it's no longer needed, just to come back later and bite you in the ass. So while I agree with your rule in general, I go for patches when there's a big chance that the patch will stop apply when upstream fixes this. Then it's hard to miss that it should be dropped when the package is updated the next time.... However there's no guarantee that will happen with my patch, so it's really up to you to go with your gut feeling. And apart from that, my autotools knowledge simply isn't as good as yours to come up with your solution (even though I definitely have seen similar things used in the past now that you point it out). > > diff --git a/debian/rules b/debian/rules > index 73a53c309..44bac00f1 100755 > --- a/debian/rules > +++ b/debian/rules > @@ -65,6 +65,10 @@ ifeq ($(DEB_HOST_ARCH_OS),hurd) > confflags += --with-libs=-lcrypt > endif > > +# Avoid using libmd even if it's installed; see > +# https://bugs.debian.org/982705. > +confflags += ac_cv_header_sha2_h=false > + > # Everything above here is common to the deb and udeb builds. > confflags_udeb := $(confflags) > > > Thanks, > > -- > Colin Watson (he/him) [cjwat...@debian.org] Regards, Andreas Henriksson
