Control: reassign -1 src:guymager 0.8.12-1 Control: severity -1 important Hi Matthias!
On Wed, Mar 31, 2021 at 05:30:17PM +0200, Matthias Klose wrote: > seen when building guymager, adding to the rules file: > > export DEB_CXXFLAGS_MAINT_APPEND = --param ggc-min-expand=0 --param > ggc-min-heapsize=0 > > The generated Makefile isn't correctly generated. The "# Command" line shows > the > passed args, which are correct, however the "^CXXFLAGS" line shows that the > flags are expanded twice, and the first time, the second --param option is > omitted, but not the parameter following that option. This happens because guymager.pro line 150 has this: QMAKE_CXXFLAGS *= $$system(dpkg-buildflags --get CXXFLAGS) The *= operator is for adding unique values (as opposed to +=). The --param flag appears twice, so it keeps only the first instance: https://doc.qt.io/qt-5/qmake-language.html#adding-unique-values You can use --param=ggc-min-expand=0 --param=ggc-min-heapsize=0, then there will be no such problem. Also there is no need at all to call dpkg-buildflags from the .pro file. debhelper passes all needed flags via command line arguments. > Feel free to reassign to guymager and lowering the severity, if that is not > a generic qmake issue. Doing so. Dear guymager maintainer(s): please consider removing lines 150 and 151 from guymager.pro, or at least replacing *= with +=. -- Dmitry Shachnev
