Your message dated Mon, 05 Apr 2021 08:15:05 +0000
with message-id <e1ltko1-000esx...@fasolo.debian.org>
and subject line Bug#985358: fixed in pitivi 2020.09.2-3
has caused the Debian Bug report #985358,
regarding pitivi: A/V out of sync in rendered videos
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
985358: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985358
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: pitivi
Version: 2020.09.2-2
Severity: grave
Tags: upstream patch
Justification: renders package unusable
Forwarded: https://gitlab.gnome.org/GNOME/pitivi/-/issues/2498
Dear Maintainer,
The version of pitivi in bullseye is affected by the bug listed above:
rendered videos have A/V out of sync by a few seconds, while they sound
just find in the preview.
I'm attaching the upstream patch that fixed the issue, already
backported to the current Debian package. I rebuilt pitivi locally with
this patch, and confirmed that it does fix the issue.
-- System Information:
Debian Release: bullseye/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500,
'unstable'), (500, 'testing'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: arm64
Kernel: Linux 5.10.0-4-amd64 (SMP w/4 CPU threads)
Locale: LANG=pt_BR.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8),
LANGUAGE=pt_BR:pt:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages pitivi depends on:
ii gir1.2-gdkpixbuf-2.0 2.42.2+dfsg-1
ii gir1.2-ges-1.0 1.18.3-1
ii gir1.2-glib-2.0 1.66.1-1+b1
ii gir1.2-gst-plugins-bad-1.0 1.18.3-1+b1
ii gir1.2-gst-plugins-base-1.0 1.18.3-1
ii gir1.2-gstreamer-1.0 1.18.3-1
ii gir1.2-gtk-3.0 3.24.24-3
ii gir1.2-pango-1.0 1.46.2-3
ii gir1.2-peas-1.0 1.28.0-2+b1
pn gstreamer1.0-audiosink <none>
ii gstreamer1.0-gl [gstreamer1.0-videosink] 1.18.3-1
ii gstreamer1.0-gtk3 [gstreamer1.0-videosink] 1.18.3-1
ii gstreamer1.0-plugins-bad [gstreamer1.0-videosink] 1.18.3-1+b1
ii gstreamer1.0-plugins-base 1.18.3-1
ii gstreamer1.0-plugins-good [gstreamer1.0-videosink] 1.18.3-1
ii gstreamer1.0-x [gstreamer1.0-videosink] 1.18.3-1
ii libc6 2.31-9
ii libcairo2 1.16.0-5
ii libglib2.0-0 2.66.7-2
ii libgstreamer1.0-0 1.18.3-1
ii libpython3.9 3.9.2-1
ii python3 3.9.2-2
ii python3-cairo 1.16.2-4+b2
ii python3-dbus 1.2.16-5
ii python3-ges-1.0 1.18.3-1
ii python3-gi 3.38.0-2
ii python3-gi-cairo 3.38.0-2
ii python3-gst-1.0 1.18.3-1
ii python3-matplotlib 3.3.4-1
ii python3-numpy 1:1.19.5-1
ii python3-xdg 0.27-2
ii python3.9 3.9.2-1
pitivi recommends no packages.
Versions of packages pitivi suggests:
pn frei0r-plugins <none>
ii gir1.2-gnomedesktop-3.0 3.38.4-1
pn gir1.2-gsound-1.0 <none>
ii gir1.2-notify-0.7 0.7.9-3
ii gstreamer1.0-libav 1.18.3-1
ii gstreamer1.0-plugins-ugly 1.18.3-1
-- no debconf information
From: Thibault Saunier <tsaun...@igalia.com>
Date: Mon, 11 Jan 2021 17:50:26 -0300
Subject: pipeline: Avoid committing the timeline while rendering
This can cause weird behavior and in particular it can lead to
de-synchronized audio/video streams.
Fixes https://gitlab.gnome.org/GNOME/pitivi/-/issues/2498
---
pitivi/editorperspective.py | 3 +++
pitivi/utils/pipeline.py | 8 ++++----
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/pitivi/editorperspective.py b/pitivi/editorperspective.py
index a25450c..49cbf61 100644
--- a/pitivi/editorperspective.py
+++ b/pitivi/editorperspective.py
@@ -128,6 +128,9 @@ class EditorPerspective(Perspective, Loggable):
# Nothing to work with, Pitivi is starting up.
return
+ if self.app.project_manager.current_project.pipeline.rendering():
+ return
+
# Commit the timeline so its nested timelines assets are refreshed.
ges_timeline.commit()
diff --git a/pitivi/utils/pipeline.py b/pitivi/utils/pipeline.py
index 95be106..c92c880 100644
--- a/pitivi/utils/pipeline.py
+++ b/pitivi/utils/pipeline.py
@@ -424,7 +424,7 @@ class SimplePipeline(GObject.Object, Loggable):
Gst.debug_bin_to_dot_file_with_ts(self._pipeline,
Gst.DebugGraphDetails.ALL,
"pitivi.error")
- if not self._rendering():
+ if not self.rendering():
self._remove_waiting_for_async_done_timeout()
self._recover()
elif message.type == Gst.MessageType.DURATION_CHANGED:
@@ -498,7 +498,7 @@ class SimplePipeline(GObject.Object, Loggable):
raise PipelineError("Couldn't get duration: Returned None")
return dur
- def _rendering(self):
+ def rendering(self):
return False
@@ -611,7 +611,7 @@ class Pipeline(GES.Pipeline, SimplePipeline):
# Nowhere to seek.
return
- if self._rendering():
+ if self.rendering():
raise PipelineError("Trying to seek while rendering")
st = Gst.Structure.new_empty("seek")
@@ -675,6 +675,6 @@ class Pipeline(GES.Pipeline, SimplePipeline):
self._was_empty = True
self._remove_waiting_for_async_done_timeout()
- def _rendering(self):
+ def rendering(self):
mask = GES.PipelineFlags.RENDER | GES.PipelineFlags.SMART_RENDER
return self._pipeline.get_mode() & mask != 0
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: pitivi
Source-Version: 2020.09.2-3
Done: Sebastian Dröge <sl...@debian.org>
We believe that the bug you reported is fixed in the latest version of
pitivi, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 985...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sebastian Dröge <sl...@debian.org> (supplier of updated pitivi package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 05 Apr 2021 10:31:38 +0300
Source: pitivi
Architecture: source
Version: 2020.09.2-3
Distribution: unstable
Urgency: medium
Maintainer: Sebastian Dröge <sl...@debian.org>
Changed-By: Sebastian Dröge <sl...@debian.org>
Closes: 985358
Changes:
pitivi (2020.09.2-3) unstable; urgency=medium
.
*
debian/patches/0002-pipeline-Avoid-committing-the-timeline-while-renderi.patch:
+ Fix audio/video sync being broken in rendered videos (Closes: #985358).
Checksums-Sha1:
4dd7266ecc1776ae3a1edcc715e4489bb8980731 2351 pitivi_2020.09.2-3.dsc
cd15b48e92b615e4d3d5b71321b84e873deb4f88 11282116 pitivi_2020.09.2.orig.tar.xz
675af5d863e5ff7e19fc647fe00ba4b3a790ef71 9192 pitivi_2020.09.2-3.debian.tar.xz
9889e57d5e2cacfe39de590c8ba5f695f3c410f9 22484
pitivi_2020.09.2-3_amd64.buildinfo
Checksums-Sha256:
1aacf714dc77c8dd5477cb21829d70b84cbb0d5362e6c5a782435832ce9c20be 2351
pitivi_2020.09.2-3.dsc
e0398cffe86135c91a4ca9eff168c1a461816b3cc29b80f70433131539d9fb43 11282116
pitivi_2020.09.2.orig.tar.xz
c8dddbd1766db13ece33135c42e9c4e7bf90b5aa0eabe447ca971992cc689238 9192
pitivi_2020.09.2-3.debian.tar.xz
2c76395ccbbac6abfd13518624884e60f47146007c1f6a4a49aac0cf955e678c 22484
pitivi_2020.09.2-3_amd64.buildinfo
Files:
c932c000b7788281bb870287ec85e105 2351 gnome optional pitivi_2020.09.2-3.dsc
e42bec86a5e01770a1066895f0fbb4ac 11282116 gnome optional
pitivi_2020.09.2.orig.tar.xz
7b306573de2d28cb72089e68f6433275 9192 gnome optional
pitivi_2020.09.2-3.debian.tar.xz
966a830465d74034186373d78e71cb96 22484 gnome optional
pitivi_2020.09.2-3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQKmBAEBCgCQFiEEf0vHzDygb5cza7/rBmjMFIbC17UFAmBqwIZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDdG
NEJDN0NDM0NBMDZGOTczMzZCQkZFQjA2NjhDQzE0ODZDMkQ3QjUSHHNsb21vQGNv
YXhpb24ubmV0AAoJEAZozBSGwte1u5cQAKlFQe2n/bM1OvEGMXpIa+otQygj25kJ
G1gOtLE6PxhJYwsRZVvwzIe0/g0fAQae7lxMoNEgR//Dasj+Z10iwL0yz8Bc1IUS
LEYN55gOkN1M/WtUmpmxz6SODPQTAbJISSLyAjqI+wmZ3M7zgkf6NdwhivATA1vp
xexye58SziKcd/k89IzCaBFa+cLBA0+GyTin01GKrTgjceN10EPLNxW38oRNY8LA
URwudFz0ob7Czm5alvR4HVVxEmsHfE73Z03szmZMUo6rVTIKVl3eG2pNtkqThFWl
yak8GMXnXqwRm/98e5VjZ2x6YMUE7Mg5deUXKgacDT4ZaoOrE7pxelCe2uv28CLg
frnJulnn4vglzdfgZQRv8U3d6F3myTXoeHMhXAPTWcoxc3Ful9LhMgT7ThgJf7Wk
MtY3/8kntrGcb62OMQCF/NXkwwEaWgOUoZ4/n+8mrwb5G5Lf/SmmIGsIEqAj4eq2
OVTduGf4vM5ZyzCrytrw35spUy5k6WHgPB9RTED+FCPle1DHekglfLgF3HuFG8Lv
1fFoi/XCeAK9mkyJYBDPVXj2E+XxW6bGNObKTZNSJPNqpqoZKh2wU/3lUE3kokI0
S2KKXpH7y0LHet1fxZ/BVvmKbbRobhA65cR0k3R2jp0JcdCyNBbNXaP1UBAze/ha
CWzMXGV8nHY1
=aCkI
-----END PGP SIGNATURE-----
--- End Message ---
