Le vendredi 02 avril 2021 à 14:56 -0400, Qianqian Fang a écrit : > On 4/2/21 9:26 AM, Sébastien Villemot wrote: > > Thanks for looking at this issue. > > > > I don’t think that creating those symlinks in iso2mesh-tools is the > > right solution. Such symlinks should only be created by the tetgen > > package, otherwise this only creates confusion over package > > boundaries. > > > > I think the right solution is to drop the symlinks, and rather to > > create a Debian-specific patch that replaces “tetgen1.5” with > > “tetgen” in brain2mesh.m. > > understood. I agree patching brain2mesh and other related demo > scripts is a better solution than the symbolic link, however, > iso2mesh has been used by other widely distributed tools, like > brainstorm, fieldtrip etc, and I am afraid that dropping this link > can lead to broken scripts (unless all upstream codes are patched).
Note that I’m not suggesting that you patch the code upstream at this stage. Only that you modify the code shipped by Debian. > can we upload this temporary fix for now, and I will add a fall-back > mechanism (in mcpath.m) in the next release of iso2mesh? once that is > added, I will remove the symbolic link. I still think that the symlink is the wrong solution. Nevertheless, in the context of the freeze, the ultimate decision will be taken by the Release Team members, who will decide to unblock (or not) your proposed fix. I therefore suggest that you submit a so-called “pre-approval” unblock request, so that we know their decision. If it is positive, then I will make the upload. For instructions on unblock requests, see: https://release.debian.org/bullseye/freeze_policy.html#appropriate (you should explicitly say in your bug report that this is a “pre- approval” unblock request) Best, -- ⢀⣴⠾⠻⢶⣦⠀ Sébastien Villemot ⣾⠁⢠⠒⠀⣿⡁ Debian Developer ⢿⡄⠘⠷⠚⠋⠀ https://sebastien.villemot.name ⠈⠳⣄⠀⠀⠀⠀ https://www.debian.org
signature.asc
Description: This is a digitally signed message part
