Hi all, 2021年4月7日(水) 18:39 Andreas Henriksson <andr...@fatal.se>: > > Control: severity -1 grave > > On Wed, Apr 07, 2021 at 11:20:18AM +0200, Bastian Germann wrote: > > Control: severity -1 important > > > > Am 07.04.21 um 11:10 schrieb Andreas Henriksson: > > > Could we please just add a patch that either just rips out the NDEBUG > > > lines (or inverts the login to #ifdef DEBUG ) ?! Such a patch could/should > > > be forwarded upstream as well.... A library should not print to stdout > > > like this! > > I am not the maintainer. > > I agree that the maintainer should have done a better job at reviewing > rather than blindly applying your patch and also verifying that the new > version actually fixes the bugs that is claimed to be closed in the > changelog. > > People must have been sleeping while writing this debian/rules > file. Most content is entirely unused because cmake build type > is *not* release! > > > You can hand in such a patch to speed up that process. > > I've submitted a merge-request that fixes the imminent problems for > review at: > https://salsa.debian.org/debian/libubootenv/-/merge_requests/3 > > Please not that I'm nowhere near a cmake expert. I've only fixed > the imminent bug and some glaring problems in debian/rules. > I've left comments in commit messages about further improvements, > but there are likely entirely different and better ways of > doing things.
Thank you for the patch. I will review this carefully. > > > I am reducing the severity as pointed out before. > > And I'm raising it back up again, because this is definitely an RC bug. > Breaking the output of fw_printenv breaks multiple programs (including > but not limited to mender-client) which parses that output. > I agree about this. Best regards, Nobuhiro -- Nobuhiro Iwamatsu
