Your message dated Sun, 11 Jul 2021 09:18:22 +0000
with message-id <e1m2vbs-0004ez...@fasolo.debian.org>
and subject line Bug#990863: fixed in libserialport 0.1.1-4
has caused the Debian Bug report #990863,
regarding libserialport0: libserialport tries to use termiox on bullseye, and 
fails to open serial ports
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
990863: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990863
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libserialport0
Version: 0.1.1-3+b1
Severity: important
Tags: upstream patch
X-Debbugs-Cc: t...@seoss.co.uk

Serial port open seems to fail on bullseye.  Strace output follows:

1512868 openat(AT_FDCWD, "/dev/ttyACM0", O_RDWR|O_NOCTTY|O_NONBLOCK) = 9
1512868 ioctl(9, TCGETS, {B9600 opost isig icanon echo ...}) = 0
1512868 ioctl(9, TIOCMGET, [TIOCM_DTR|TIOCM_RTS|TIOCM_CTS]) = 0
1512868 ioctl(9, TCGETX, 0x55cd7cc80df0) = -1 ENOTTY (Inappropriate ioctl for 
device)
1512868 close(9)                        = 0
1512868 write(2, "sr: ", 4)             = 4
1512868 write(2, "serial-libsp: Error opening port"..., 71) = 71
1512868 write(2, "No devices found.\n", 18) = 18

Applying upstream commit 6f9b03e597ea fixes the issue.  I tested this
with:

/usr/local/bin/sigrok-cli --driver=rdtech-tc:conn=/dev/ttyACM0 --continuous

Patch here:

https://github.com/sigrokproject/libserialport/commit/6f9b03e597ea7200eb616a4e410add3dd1690cb1

I suspect that libserialport0 will fail to open all serial ports on
bullseye without this fix, so this bug may unfortunately be RC?

Cheers,

Tim.



-- System Information:
Debian Release: 11.0
  APT prefers testing-security
  APT policy: (500, 'testing-security'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-7-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_WARN, TAINT_CRAP
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libserialport0 depends on:
ii  libc6  2.31-12

libserialport0 recommends no packages.

libserialport0 suggests no packages.

-- no debconf information
>From 6f9b03e597ea7200eb616a4e410add3dd1690cb1 Mon Sep 17 00:00:00 2001
From: Karl Palsson <ka...@etactica.com>
Date: Fri, 11 Jun 2021 17:07:09 +0000
Subject: [PATCH] HACK: don't even check for termiox

termiox was removed from linux in e0efb3168d34
Some more information available in 
https://www.spinics.net/lists/linux-serial/msg41926.html

Attempting to use the termiox ioctls on more modern kernels results in
"Inappropriate IOCTL" errors.

While the "right" solution might be to remove the termiox code from the
linux path, simply not checking for termiox builds a libserialport that
functions on modern linux kernels.

Signed-off-by: Karl Palsson <ka...@etactica.com>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index b1af16f..a26b851 100644
--- a/configure.ac
+++ b/configure.ac
@@ -112,7 +112,7 @@ AC_SYS_LARGEFILE
 AC_TYPE_SIZE_T
 
 # Check for specific termios structures.
-AC_CHECK_TYPES([struct termios2, struct termiox],,,
+AC_CHECK_TYPES([struct termios2],,,
        [[#include <linux/termios.h>]])
 AC_CHECK_MEMBERS([struct termios.c_ispeed, struct termios.c_ospeed,
                struct termios2.c_ispeed, struct termios2.c_ospeed],,,
-- 
2.30.2


--- End Message ---
--- Begin Message ---
Source: libserialport
Source-Version: 0.1.1-4
Done: Jonathan McDowell <nood...@earth.li>

We believe that the bug you reported is fixed in the latest version of
libserialport, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 990...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jonathan McDowell <nood...@earth.li> (supplier of updated libserialport package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 10 Jul 2021 17:21:59 +0100
Source: libserialport
Architecture: source
Version: 0.1.1-4
Distribution: unstable
Urgency: high
Maintainer: Debian Electronics Packaging Team 
<pkg-electronics-de...@lists.alioth.debian.org>
Changed-By: Jonathan McDowell <nood...@earth.li>
Closes: 990863
Changes:
 libserialport (0.1.1-4) unstable; urgency=high
 .
   * Avoid the use of termiox now the kernel has dropped support for it.
     Thanks to Tim Small. (Closes: #990863)
Checksums-Sha1:
 e0b60197d05fe43b19b058f887ac4b49d0b05288 2124 libserialport_0.1.1-4.dsc
 db54316ffa7e84752060a85896c3821de83923bb 3976 
libserialport_0.1.1-4.debian.tar.xz
 0a48f0efd83238a580446eaa084baf02b2692129 6335 
libserialport_0.1.1-4_amd64.buildinfo
Checksums-Sha256:
 56059a0628821bcc4fea7d286e3b60d8cca50ecfc0395f9030a2ef9690e96937 2124 
libserialport_0.1.1-4.dsc
 20b3ea8dc494dc60552cdf55f16155c939534051be70e77278cb1cd0d12faa61 3976 
libserialport_0.1.1-4.debian.tar.xz
 0c8eeb3c9a1f3f2afc07323764d74b67c9a737cfd1e1fe47a6a403ebe229904c 6335 
libserialport_0.1.1-4_amd64.buildinfo
Files:
 7e8af4fb38f6c00dca137458cf45d930 2124 libs optional libserialport_0.1.1-4.dsc
 9e642029282a142f7a42d9606312b177 3976 libs optional 
libserialport_0.1.1-4.debian.tar.xz
 5e0c72d7543c8c72ca90cef3e8826776 6335 libs optional 
libserialport_0.1.1-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/S8txYRw4wP3eXWjSgDzSK903QIFAmDqsysACgkQSgDzSK90
3QIotRAAlvCBDYxbmouwUfwHIEwplyUhF4bi2qc+sKfpGntl4mRjp2BuoZT4EYAa
ogxwTvWlt/UMoNxpNZ8UsbwAq3KAWSEdrUIZoXYUObSkeDesVOefCerhXgkHyLpj
aJS9p9Gxij+LgRYnIJwA+j6lJhET+/KizmazYmVW+2YDPTCuv2J1gVlVD4v93aed
ysw840NeRhjbFwZLRKWQ/+HTdWucfUg0A7eRd489wefYwTy82oID3fvWODoWd8Z/
NS7axhHHGq1AKwZOMpNLRAC0m1VSWmZqnD1ZGENpW1nnzht5cViJUfdA3gmB2XaN
M/c3qvMxlK8R6tJEqj0yazSh82AinGziEP2vhTtPbt3DOKoSJOILPoRofnW56QoP
cWJpxWE0C+JthLnOLDiRYZnCioRW3DOwKzUr9A7ftkJZmHPuNkLAfeLex8egYxmM
w8OLrMnsPKiDEoKXoqLbhwRIfmr2sWSDGnhbORyPDcZyCiVWpFzlQJuAaEROnShs
uqjLY/9rBU6E3q0cCIKwAe5+7ILcUR6jB6xgKbt15M4cJn4EsE6Lqh+d5Om46DYC
I0pdSLAAspXor41Wa9jE6SDq7qsc20wqh+anm1UDG1Nsx6rYLVW8cRaqioKvPr0H
+1Rvi50r4zhVWSA+AN56RAjufHag/9k8sRvPmedS9ztYQyq87ao=
=1ieu
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to