Hello,

I'm sorry to ask, but I fear I need additional information, please.
It seems to me that this patch merely circumvent the change in
ImageMagik to allow the handling of eps file during the construction
of the package. Am I right, or is it only disabling the dangerous
parts of the converter while retrieving the parts we need?

Sorry to ask, I'm very bad with ImageMagik.

Even if it's re-enabling the conversion of eps files for the package
building, I guess that this is a good emergency solution to not delay
the release too much, provided that we trust the eps files that come
with ns-3. Thanks for the proposal.

But I would prefer not to live with such a complex and even somewhat
dangerous patch in my package, so I'm curious about other solutions
that would allow to convert eps to png without ImageMagik. Maybe using
gimp and Script-Fu?

Thanks for that patch anyway,
Mt

Le Fri, Jul 16, 2021 at 06:21:21PM +0200, Dennis Filder a écrit :
> Control: tag -1 patch
> 
> With this patch the build finished for me.
> 
> Regards,
> Dennis Filder

> Description: Override overly strict ImageMagick security policy (#987504)
>  This patch derives a more permissive ImageMagick security policy from
>  the system default.
> Author: Dennis Filder <d.fil...@web.de>
> Last-Update: 2021-07-16
> Bug-Debian: https://bugs.debian.org/991061
> --- a/ns-3.31/doc/models/Makefile
> +++ b/ns-3.31/doc/models/Makefile
> @@ -496,6 +496,8 @@
>  
>  RESCALE = ../../utils/rescale-pdf.sh
>  
> +POLFILE = "/etc/$(shell convert -version|sed -n '/^Version: /s@Version: 
> ImageMagick \([[:digit:]]\+\)\..*@ImageMagick-\1@p')/policy.xml"
> +
>  %.eps : %.dia
>       @echo dia $(notdir $<)
>       @$(DIA) -t eps $< -e $@ >/dev/null
> @@ -506,7 +508,9 @@
>  
>  %.png : %.eps
>       @echo convert $(notdir $<)
> -     @$(CONVERT) $< $@ >/dev/null
> +     test -d ../../../debian/tmp/ImageMagick || mkdir -p 
> ../../../debian/tmp/ImageMagick
> +     test -f ../../../debian/tmp/ImageMagick/policy.xml || sed -e '/<policy 
> domain="coder" rights="none" pattern="PS" .>/s@"none"@"read|write"@' 
> "$(POLFILE)" > ../../../debian/tmp/ImageMagick/policy.xml
> +     XDG_CONFIG_HOME="$(shell pwd)/../../../debian/tmp" $(CONVERT) $< $@ 
> >/dev/null
>  
>  %.pdf : %.eps
>       @echo epstopdf $(notdir $<)
> @@ -556,6 +560,7 @@
>  clean:
>       -rm -rf $(BUILDDIR)/*
>       -rm -rf $(SOURCETEMP)
> +     -rm -Rf ../../../debian/tmp/ImageMagick
>  
>  frag: pickle
>       @if test ! -d $(BUILDDIR)/frag; then mkdir $(BUILDDIR)/frag; fi


-- 
The web was not envisioned as a form of television when it was invented. 
But, like it or not, it is rapidly resembling TV: linear, passive,
programmed and inward-looking.   --  Hossein Derakhshan
        https://medium.com/matter/the-web-we-have-to-save-2eb1fe15a426

Attachment: signature.asc
Description: PGP signature

Reply via email to