On Thu, Jun 15, 2006, Alexis Sukrieh wrote:

> Thanks a lot for the patch, I'm going to test it on a 32bit arch very
> soon.

   I do not like this patch because it assumes that long has the same
size as void *, which is true in practice but not guaranteed. A more
correct patch did this:

    union { int i; void *p; } dummy;
    memcpy(&ptModAmiga, (Uint8 *)pMixmodule + sizeof(dummy), sizeof(void *));

   It is not absolutely necessary to have the union, but it guarantees
that the code with also work on platforms where ints are bigger than
pointers (though I don't know any modern platform that does that).

   This patch was in tecnoballz 0.91cvs20060501-1.3 but for some reason
it disappeared from 0.91cvs20060612-1.

-- 
Sam.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to