Hi Scott > > The tests look easy enough to fix, so it's worth trying to do that. (and > > it's in the Debian group on salsa to make that easy :)
I've looked at them and fixed most of the tests locally without issues. I guess I should push that somewhere so that it is visible. I'll start a draft PR with upstream for it. > > I'm a bit surprised by some of the data changes though -- apparently > > England is no longer a part of the UK. Yes, that's quite complicated, but > > the ISO-3166-2 info does still list ENG and EAW. As the pycountry tests > > highlight, those divisions disappeared from iso_3166-2.json with the > > switch over to a different data harvester. > > > > https://www.iso.org/obp/ui/#iso:code:3166:GB > > > > Is that correct and intended? > > Good question. I not sure how to adapt one test to the new data, so I'll > leave it on to you to deal with. I'm happy to look for alternate sets of divisions to replace these UK ones in the test if that's appropriate. I guess I need the input from Tobias to know whether the pycountry test failure has found a bug in the pycountry test code or a bug in the iso-codes data. The test failures regarding AL-BU look like an intended data change that needs a fix in the pycountry data. Finding a different second level division and then coming back to the national and first level divisions is needed... Tobias might have a suggestion there, otherwise I'll trawl the ISO database to find a different test case. https://www.iso.org/obp/ui/#iso:code:3166:AL https://en.wikipedia.org/wiki/ISO_3166-2:AL > Please address this before it gets auto-removed. Yes, will do. (and just discussing this bug keeps resetting the autoremoval timer, of course!) cheers Stuart -- Stuart Prescott http://www.nanonanonano.net/ stu...@nanonanonano.net Debian Developer http://www.debian.org/ stu...@debian.org GPG fingerprint 90E2 D2C1 AD14 6A1B 7EBB 891D BBC1 7EBB 1396 F2F7
