Package: pagekite
Version: 1.5.2.200603-2
Severity: grave
Tags: patch
Justification: renders package unusable

As described in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1004295,
incoming pagekite connections don't work on Debian 11. If you run your own
frontend on that version of Debian (or on Ubuntu focal for that matter),
nothing works.

I've attached the reverse of the patch from that bug which is all that's
needed to fix pagekite in unstable.

Francois

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.16.0-2-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_CA.utf8, LC_CTYPE=fr_CA.utf8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages pagekite depends on:
ii  ca-certificates        20211016
ii  daemon                 0.8-1
ii  init-system-helpers    1.62
ii  python3                3.9.8-1
ii  python3-openssl        21.0.0-1
ii  python3-six            1.16.0-3
ii  python3-socksipychain  2.1.2-1

pagekite recommends no packages.

pagekite suggests no packages.

-- Configuration Files:
/etc/pagekite.d/10_account.rc [Errno 13] Permission non accordée: 
'/etc/pagekite.d/10_account.rc'
/etc/pagekite.d/90_debian_certs.rc [Errno 13] Permission non accordée: 
'/etc/pagekite.d/90_debian_certs.rc'

-- no debconf information
commit 695ae5c46610393b8b4e950466c643d9c58cbce1
Author: Francois Marier <franc...@debian.org>
Date:   Sat Feb 26 18:41:37 2022 -0800

    Fix incoming connections (patch from #1004295).

diff --git a/debian/changelog b/debian/changelog
index e8f50ba..4cef3ef 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,7 @@ pagekite (1.5.2.200603-2.1) unstable; urgency=medium
 
   * Non-maintainer upload.
   * Log messages in /var/log/pagekite/pagekite.log (closes: #910028).
+  * Fix incoming connections (patch from #1004295).
 
  -- Francois Marier <franc...@debian.org>  Sat, 26 Feb 2022 18:38:24 -0800
 
diff --git a/pagekite/proto/conns.py b/pagekite/proto/conns.py
index 3da9272..2c9fc04 100755
--- a/pagekite/proto/conns.py
+++ b/pagekite/proto/conns.py
@@ -1975,8 +1975,8 @@ class FastPingHelper(threading.Thread):
         data = None
       try:
         if data:
-          if '\nHost: ping.pagekite' in data:
-            client.send(self.rejection)
+          if b'\nHost: ping.pagekite' in data:
+            client.send(self.rejection.encode("utf-8"))
             client.close()
             self.fast_pinged.append(obfuIp(addr[0]))
           else:
diff --git a/pagekite/proto/selectables.py b/pagekite/proto/selectables.py
index 56705f5..ed1967c 100755
--- a/pagekite/proto/selectables.py
+++ b/pagekite/proto/selectables.py
@@ -344,7 +344,7 @@ class Selectable(object):
   def EatPeeked(self, eat_bytes=None, keep_peeking=False):
     if not self.peeking: return
     if eat_bytes is None: eat_bytes = self.peeked
-    discard = ''
+    discard = b''
     while len(discard) < eat_bytes:
       try:
         bytecount = eat_bytes - len(discard)

Reply via email to