Your message dated Wed, 1 Jun 2022 09:37:00 -0400
with message-id
<CANTAOdyMLb67U6gKrJOj5KhMg+90wVDP5njy399zN=e_3tc...@mail.gmail.com>
and subject line Re: thinkfan FTBFS on riscv
has caused the Debian Bug report #1011953,
regarding thinkfan FTBFS on riscv
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1011953: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1011953
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: thinkfan
Version: 1.3.1-1
Severity: serious
Tags: ftbfs patch
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: ab.bea...@gmail.com
Dear Maintainer,
The thinkfan package has a ftbfs issue on riscv64.
Full buildd log here:
https://buildd.debian.org/status/fetch.php?pkg=thinkfan&arch=riscv64&ver=1.3.1-1&stamp=1649865911&raw=0
I am including a patch which fixes the problem. Please consider applying it in
the next upload. Thank you.
-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: riscv64
Kernel: Linux 5.18.0-starfive-5.18 (SMP w/2 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL
set to en_US.UTF-8), LANGUAGE=en_US.UTF-8
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages thinkfan depends on:
ii init-system-helpers 1.63
ii libatasmart4 0.19-5
ii libatomic1 12.1.0-2
ii libc6 2.33-7
ii libgcc-s1 12.1.0-2
ii libstdc++6 12.1.0-2
ii libyaml-cpp0.7 0.7.0+dfsg-8
thinkfan recommends no packages.
thinkfan suggests no packages.
-- no debconf information
fix ftbfs on riscv64
Alan Beadle <ab.bea...@gmail.com>
--- thinkfan-1.3.1.orig/CMakeLists.txt
+++ thinkfan-1.3.1/CMakeLists.txt
@@ -8,6 +8,8 @@ cmake_minimum_required(VERSION 3.0)
# Generate absolute paths or something
cmake_policy(SET CMP0015 NEW)
+set(THREADS_PREFER_PTHREAD_FLAG ON)
+
find_package(PkgConfig)
find_package(Threads)
pkg_check_modules(SYSTEMD "systemd")
--- End Message ---
--- Begin Message ---
I am closing this bug, because glibc 2.34 will break the above
solution (the cmake directive will be ignored in the future).
Instead this will probably have to be fixed at the compiler level,
when gcc adds inline support for subword atomics in riscv. This is
pending.
More information can be found at these links:
[0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1012058
[1] https://blog.jiejiss.com/A-RISC-V-gcc-pitfall-revealed-by-a-glibc-update/
-Alan Beadle
--- End Message ---
