Hi again,
Axel Beckert wrote:
> Yep, this change makes pconsole and links2 build fine again:
>
> - _install_file_to_path($mode, $source, $target);
> + _install_file_to_path(1, $mode, $source, $target);
Compared with debhelper 13.10 builds the lintian overrides file is
installed as before. Same timestamp too. (Checked with diffoscope
against my pbuilder builds before the upload of pconsole and links2.)
Other files though seem to have gotten updated timestamps. But this
likely doesn't come from my change but from 13.11 changes. I suspect
that we'll have some reproducibility issues afterwards.
> I'm though not 100% sure if the 1 is really necessary here of if a 0
> would suffice. But the 1 seems to be on the safe side, might be a tiny
> performance impact, though.
This is what I gathered from the variable name consider_using_root.
Interestingly this variable is later used negated:
my $use_root = !$consider_using_root && should_use_root();
So use root if we don't consider using root and should use root? Not
sure if just the variable names are unfortunate or if there's still a
logic issue in there.
Will upload anyway as it clearly improves the situation and we need a
fix quickly.
Niels: Feel free to improve my fix in the next upload in case I
understood some of the new code wrongly.
Regards, Axel
--
,''`. | Axel Beckert <a...@debian.org>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
