Your message dated Fri, 23 Dec 2022 15:43:42 +0000
with message-id <e1p8kd0-0080pc...@fasolo.debian.org>
and subject line Bug#1025096: fixed in nanoc 4.12.14-1
has caused the Debian Bug report #1025096,
regarding nanoc: FTBFS in bullseye, and will also FTBFS in bookworm next year
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1025096: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1025096
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: src:nanoc
Version: 4.11.23-1
Severity: serious
Tags: ftbfs, patch

Dear maintainer:

During a rebuild of all packages in bullseye I noticed that this package does not build from source anymore:

  1) Nanoc::Core has up-to-date version information
Failure/Error: expect(described_class.version_information).to match(/–#{current_year} /)

expected "Nanoc 4.11.23 © 2007–2021 Denis Defreyne.\nRunning ruby 2.7.4 (2021-07-07) on x86_64-linux-gnu with RubyGems 3.2.5.\n" to match /–2022 /
       Diff:
       @@ -1,2 +1,3 @@
       -/–2022 /
       +Nanoc 4.11.23 © 2007–2021 Denis Defreyne.
+Running ruby 2.7.4 (2021-07-07) on x86_64-linux-gnu with RubyGems 3.2.5.


This happens because there is a test which expects the current year to be equal to 2021, which naturally fails now that we are in 2022, and will fail forever from now on.

I include a trivial patch to disable the test in bullseye.

Note also that the current version in testing/unstable also has the bug in "latent state", as it will fail from 2023 onwards. To check this, try building the package after setting current_year to 2023 as in poc.diff.txt and you will see what happens next year.

Thanks.

[ p.s. I'm having a dejavu. Didn't I report something like this a few years ago? ]
--- a/nanoc-core/spec/nanoc/core_spec.rb
+++ b/nanoc-core/spec/nanoc/core_spec.rb
@@ -3,8 +3,8 @@
 require 'nanoc/version'
 
 describe Nanoc::Core do
-  it 'has up-to-date version information' do
-    current_year = Date.today.year
-    expect(described_class.version_information).to match(/–#{current_year} /)
-  end
+#  it 'has up-to-date version information' do
+#    current_year = Date.today.year
+#    expect(described_class.version_information).to match(/–#{current_year} /)
+#  end
 end
--- a/nanoc-core/spec/nanoc/core_spec.rb
+++ b/nanoc-core/spec/nanoc/core_spec.rb
@@ -4,7 +4,7 @@ require 'nanoc/version'
 
 describe Nanoc::Core do
   it 'has up-to-date version information' do
-    current_year = Date.today.year
+    current_year = 2023
     expect(described_class.version_information).to match(/–#{current_year} /)
   end
 end

--- End Message ---
--- Begin Message ---
Source: nanoc
Source-Version: 4.12.14-1
Done: Antonio Terceiro <terce...@debian.org>

We believe that the bug you reported is fixed in the latest version of
nanoc, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1025...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Antonio Terceiro <terce...@debian.org> (supplier of updated nanoc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 23 Dec 2022 11:24:01 -0300
Source: nanoc
Architecture: source
Version: 4.12.14-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Ruby Team 
<pkg-ruby-extras-maintain...@lists.alioth.debian.org>
Changed-By: Antonio Terceiro <terce...@debian.org>
Closes: 1025096
Changes:
 nanoc (4.12.14-1) unstable; urgency=medium
 .
   * Team upload
 .
   [ Pirate Praveen ]
   * New upstream version 4.12.7 (upstream switched to terser from uglifier)
   * Drop 0016-filesystem_spec-skip-tests-that-fail-on-debian.patch (merged
     upstream) and refresh other patches (remove fuzz).
   * TODO: need psych 4.0
 .
   [ Antonio Terceiro ]
   * New upstream version 4.12.14
   * Refresh patches
   * Bump Build-Depends: on ruby-contracts to (>= 0.17)
   * Drop build dependencies on ruby-coffee-script
   * debian/ruby-tests.rake: run all test tasks even after one fails
   * debian/ruby-tests.rake: don't run coffee-script test
   * Bump build dependency on ruby-haml to (>= 6.0)
   * debian/rules: ignore test failure under ruby3.0
   * Disable test that checks for the current year (Closes: #1025096)
Checksums-Sha1:
 1aeeeca3ad27b70cf8e80ff88671d00315a20573 3321 nanoc_4.12.14-1.dsc
 f412698ab5a1411568369bd3f0ebc988423e3c7b 347902 nanoc_4.12.14.orig.tar.gz
 b177110089787ade6d237b02d5fc33f4c6a1ad33 15176 nanoc_4.12.14-1.debian.tar.xz
 428031e8b29db6b6eb8504a0e68e1c1264ea1d60 18232 nanoc_4.12.14-1_source.buildinfo
Checksums-Sha256:
 d2ba13d7c2021f9ba20d4641ca3768a8a749af25661bd8c5e9ba2088048e14da 3321 
nanoc_4.12.14-1.dsc
 c1fa47c2299677e75263d0da57de9c23a83108a88a39bfaf8451a9b32b7e2486 347902 
nanoc_4.12.14.orig.tar.gz
 fee3dfe84b441b0ad41af1fcc4e04285b8008aad221c009f26e9b3e3c956a7c1 15176 
nanoc_4.12.14-1.debian.tar.xz
 3785bae24c956b7a8f1b04bb761b9d6d4bc77d0bf555e99632be817723524c43 18232 
nanoc_4.12.14-1_source.buildinfo
Files:
 ab5a62c5e324585c8019e29103763ce9 3321 web optional nanoc_4.12.14-1.dsc
 b105c2ce374e0067761a7e645a175027 347902 web optional nanoc_4.12.14.orig.tar.gz
 bacb1155ac21ae2431bb9ac47cf299b9 15176 web optional 
nanoc_4.12.14-1.debian.tar.xz
 d4cb1b2d080fccfbd3755461ce2c0649 18232 web optional 
nanoc_4.12.14-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEst7mYDbECCn80PEM/A2xu81GC94FAmOlw0UACgkQ/A2xu81G
C95NXw//Y0vPydBMDIfImipikjKdhzt37gl5xARBFkesZjIF1fW8h8JRwvlXVZ3o
f0icRD+WS+t7o0V5jWPWVNuBMkPC9Tp8WZnUIUps2PE8LMY8Ufb2wdBjPCyA6AUw
pzcd3W7HAQwLX0DknBft+puBh2UxHnIsoNoNv72WOpH5oYHaTS4eEUxNFhmRt1m0
sI9U/iLxNCl+4dHR89m19XlfNjyykAvEMJupWvcrtFHG5kkgDGrKsypDg82SkMl1
GE1rJ+qgrdmi2L/nJOWumyHmE9+9vd8YoHAFsXIXqi3vKDqehM1HNv4Kz3qHHNzf
uoUEWLr9Y02uARhwU8ZjOLL9kN151EBQrsMBkHAiyHDBQ2RWCpGEclOTYKcCKkwL
oeqQlWHA+AoA/TX2MflrtHI1HbbBxsCCB9jfaewBXhxQ+UpqUiNlpzAG6gpKQ/+3
tsaaa1GSMobWCAOKKTTzd9ii04cALhPirU0vVxWiV0qPjobtRodZON9+4AvWVjXk
kwYXp1Pc9rmsq60lVfpaO95RrDJs1bUvxjg+xu71slGo7AjSgcZY0CTG2WB3L8RU
oDtZvmVVElLB66hR3zdyWoi1iYwcLGaPAHOKne8LiybesY9Ey/B5OpTSgS/T16cz
JyphcZllh75yORe9ON18MYhUL87vqOpxbKNMw8YQDittoNuXMIc=
=DXdb
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to