On Tue, 20 Dec 2022 20:27:02 +0100, gregor herrmann wrote:

> > > #     Failed test (t/cz-03zlib-v1.t at line 713)
> > > #          got: 1
> > > #     expected: -3
> > > # Looks like you failed 1 test of 471.
> > > t/cz-03zlib-v1.t ................ 
> > > 1..471
> 
> I think this has to do with zlib1g-dev 1:1.2.13.dfsg-1 and
> libcompress-raw-zlib-perl and (a bit)
> https://github.com/pmqs/Compress-Raw-Zlib/issues/20
> 
> If I rebuild libcompress-raw-zlib-perl (against zlib 1.2.13) and then
> rebuild libio-compress-perl, its tests pass.
> 
> 
> PS: This also reminds me that #1024179 in libcompress-raw-zlib-perl
> is still not closed.


And using the same patch as in #1024179 als make this test here pass:

#v+
--- a/t/cz-03zlib-v1.t
+++ b/t/cz-03zlib-v1.t
@@ -14,7 +14,8 @@
 use CompTestUtils;
 use Symbol;
 
-use constant ZLIB_1_2_12_0 => 0x12C0;
+use constant ZLIB_1_2_12_0 => '1.2.12';
+my $Zlib_ver = Compress::Raw::Zlib::zlib_version ;
 
 BEGIN
 {
@@ -704,7 +705,7 @@
 
     # Z_STREAM_END returned by 1.12.2, Z_DATA_ERROR for older zlib
     # always Z_STREAM_ENDin zlib_ng
-    if (ZLIB_VERNUM >= ZLIB_1_2_12_0 || Compress::Raw::Zlib::is_zlibng)
+    if ($Zlib_ver gt ZLIB_1_2_12_0 || Compress::Raw::Zlib::is_zlibng)
     {
         cmp_ok $status, '==', Z_STREAM_END ;
     }
#v-

Does this make sense?


Cheers,
gregor


-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   

Attachment: signature.asc
Description: Digital Signature

Reply via email to