On Mon, Jan 09, 2023 at 02:04:22PM +0000, Holger Levsen wrote: > control: reopen -1 > thanks > > librepo 1.14.5-2 still fails to build as 1.14.5-1 did, see > https://buildd.debian.org/status/package.php?p=librepo
I "improved" it by also breaking the build on all other architectures... :-( The things that happen when trying to fix a problem you cannot reproduce. Patch with the missing import added is attached. > cheers, > Holger Sorry for the mess Adrian
>From abed2856f5a35c86e03851a94a9e4d92c95c1386 Mon Sep 17 00:00:00 2001 From: Adrian Bunk <b...@debian.org> Date: Mon, 9 Jan 2023 20:06:46 +0200 Subject: test_yum_package_downloading.py: Don't hardcode a value for EOPNOTSUPP For historical reasons, errno numbers are not the same on all architectures (compatibility with other operating systems already available on the same hardware was considered more important than having the same numbers on all Linux architectures). Use errno.EOPNOTSUPP instead of hardcoding a number. --- tests/python/tests/test_yum_package_downloading.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/python/tests/test_yum_package_downloading.py b/tests/python/tests/test_yum_package_downloading.py index 0364be0..ff74656 100644 --- a/tests/python/tests/test_yum_package_downloading.py +++ b/tests/python/tests/test_yum_package_downloading.py @@ -6,6 +6,7 @@ import hashlib import unittest import tempfile import xattr +import errno import tests.servermock.yum_mock.config as config @@ -758,7 +759,7 @@ class TestCaseYumPackagesDownloading(TestCaseWithServer): "user.Librepo.DownloadInProgress".encode("utf-8"), "".encode("utf-8")) except IOError as err: - if err.errno == 95: + if err.errno == errno.EOPNOTSUPP: self.skipTest('extended attributes are not supported') raise -- 2.30.2