Source: photoqt
Version: 3.3+ds-1
Severity: serious
Tags: ftbfs patch
Justification: fails to build from source (but built successfully in the past)

Dear Maintainer,

The latest photoqt upload failed to build on mips64el, m68k and riscv64.
mips64el is a release architecture, this I set severity to serious.

The error is:

  Traceback (most recent call last):
    File "<string>", line 1, in <module>
  ModuleNotFoundError: No module named 'pychromecast'
  CMake Error at CMakeLists.txt:386 (message):
    ** Unable to import PyChromecast, make sure it is installed.  Enabling the
    CHROMECAST_PIPINSTALL option allows CMake to try to install it locally
    using pip.


  -- Configuring incomplete, errors occurred!

I have attached a patch which should fix this problem. At least it seems to
do so on riscv64.

Also, I think with my change you can drop disable-pychromecast patch which
is currently commented out anyway.

--
Dmitry Shachnev
--- photoqt-3.3+ds/debian/rules
+++ photoqt-3.3+ds/debian/rules
@@ -13,10 +13,7 @@
 ifeq ($(DEB_BUILD_ARCH_OS),kfreebsd)
     MAGICK = -DGRAPHICSMAGICK=OFF -DIMAGEMAGICK=OFF
 endif
-ifeq ($(DEB_BUILD_ARCH_OS),ia64)
-    CHROMECAST = -DCHROMECAST=OFF
-endif
-ifeq ($(DEB_BUILD_ARCH_OS),x86_64)
+ifneq (,$(filter $(DEB_BUILD_ARCH),ia64 kfreebsd-amd64 kfreebsd-i386 sparc64 sh4 riscv64 m68k hppa mips64el))
     CHROMECAST = -DCHROMECAST=OFF
 endif
 ifeq ($(DEB_BUILD_ARCH_OS),hppa)

Attachment: signature.asc
Description: PGP signature

Reply via email to