Nicholas D Steeves <s...@debian.org> writes: > I've moved this discussion from debian-emacsen to the relevant bug. > Please remove debian-emacsen from CC and add me to CC for all > follow-ups. >
Dropped debian-emacsen@. > Manphiz <manp...@gmail.com> writes: > >> Manphiz <manp...@gmail.com> writes: >> >>> >>> Thanks Nicholas! I used licensecheck and checked manually and updated >>> d/copyright accordingly in my merge request[1]. PTAL, thanks! >>> >>> [1] https://salsa.debian.org/debian/silversearcher-ag/-/merge_requests/1 >> >> Friendly ping. > > haha @enable_pcre2_support.patch:L478 > > Thanks for adding some copyright info; this will cover a "patches > applied" view, but doesn't cover the "patches unapplied" source package > (orig.tar, debian.tar, dsc). If you manually evaluate the rules in > d/copyright you'll see that this patch becomes misattributed to the > debian/* holder, which gets even more confusing since you set yourself > as the patch author ;) Yes, I understand you synthesised commits, and > I'm fine with that, but please finish fixing up d/copyright. > Makes sense. Updated accordingly. > changelog: Please enclose "Closes: #999962" in parentheses in order to > follow the style that is already in use by this package's maintainer; > it's technically still Majime Mizuno's package, after all. > Done. > Then finalise the changelog and build the package. > Done as well. > Finally, learn about what an "nmudiff" is, and file one at the relevant > bug. > To be careful I'd like to have you take another look before doing so[1] :) BTW, I'm not a DD or DMD yet so I'm probably not able to submit to delayed queue yet, right? > Thanks, > Nicholas > [1] https://salsa.debian.org/debian/silversearcher-ag/-/merge_requests/1/diffs -- Manphiz
signature.asc
Description: PGP signature
