Your message dated Tue, 24 Oct 2023 01:35:00 +0000
with message-id <e1qv6jw-00cztu...@fasolo.debian.org>
and subject line Bug#1042731: fixed in roundcube-plugin-keyboard-shortcuts 3.1-1
has caused the Debian Bug report #1042731,
regarding The packaged plugin "keyboard_shortcuts" does not work with roundcube
v1.6.1
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1042731: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1042731
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: roundcube-plugins-extra
Version: 1.4.10+1-4
The plugin "keyboard_shortcuts" should be either fixed or replaced with another
plugin.
Error log:
=== cut ===
[03-Oct-2023 17:23:13 UTC] PHP Warning: Undefined property: rcmail::$imap in
/usr/share/roundcube/plugins/keyboard_shortcuts/keyboard_shortcuts.php on line
104
[03-Oct-2023 17:23:13 UTC] PHP Fatal error: Uncaught Error: Call to undefined
method rcmail::imap_connect() in
/usr/share/roundcube/plugins/keyboard_shortcuts/keyboard_shortcuts.php:105
Stack trace:
#0 /usr/share/roundcube/program/lib/Roundcube/rcube_plugin_api.php(518):
keyboard_shortcuts->html_output()
#1 /usr/share/roundcube/program/include/rcmail_output_html.php(1456):
rcube_plugin_api->exec_hook()
#2 [internal function]: rcmail_output_html->xml_command()
#3 /usr/share/roundcube/program/include/rcmail_output_html.php(1322):
preg_replace_callback()
#4 /usr/share/roundcube/program/include/rcmail_output_html.php(825):
rcmail_output_html->parse_xml()
#5 /usr/share/roundcube/program/include/rcmail_output_html.php(654):
rcmail_output_html->parse()
#6 /usr/share/roundcube/program/include/rcmail.php(296):
rcmail_output_html->send()
#7 /usr/share/roundcube/index.php(278): rcmail->action_handler()
#8 {main}
thrown in
/usr/share/roundcube/plugins/keyboard_shortcuts/keyboard_shortcuts.php on line
105
[04-Oct-2023 10:19:41 UTC] PHP Warning: Undefined property: rcmail::$imap in
/usr/share/roundcube/plugins/keyboard_shortcuts/keyboard_shortcuts.php on line
104
[04-Oct-2023 10:19:41 UTC] PHP Warning: Undefined property: rcmail::$imap in
/usr/share/roundcube/plugins/keyboard_shortcuts/keyboard_shortcuts.php on line
107
[04-Oct-2023 10:19:41 UTC] PHP Fatal error: Uncaught Error: Call to a member
function get_capability() on null in
/usr/share/roundcube/plugins/keyboard_shortcuts/keyboard_shortcuts.php:107
Stack trace:
#0 /usr/share/roundcube/program/lib/Roundcube/rcube_plugin_api.php(518):
keyboard_shortcuts->html_output()
#1 /usr/share/roundcube/program/include/rcmail_output_html.php(1456):
rcube_plugin_api->exec_hook()
#2 [internal function]: rcmail_output_html->xml_command()
#3 /usr/share/roundcube/program/include/rcmail_output_html.php(1322):
preg_replace_callback()
#4 /usr/share/roundcube/program/include/rcmail_output_html.php(825):
rcmail_output_html->parse_xml()
#5 /usr/share/roundcube/program/include/rcmail_output_html.php(654):
rcmail_output_html->parse()
#6 /usr/share/roundcube/program/include/rcmail.php(296):
rcmail_output_html->send()
#7 /usr/share/roundcube/index.php(278): rcmail->action_handler()
#8 {main}
thrown in
/usr/share/roundcube/plugins/keyboard_shortcuts/keyboard_shortcuts.php on line
107
=== cut ===
The following patch solves the critical issues:
=== cut ===
--- /usr/share/roundcube/plugins/keyboard_shortcuts/keyboard_shortcuts.php.orig
2023-10-04 12:19:19.182581433 +0200
+++ /usr/share/roundcube/plugins/keyboard_shortcuts/keyboard_shortcuts.php
2023-10-04 12:31:59.561591110 +0200
@@ -101,12 +101,12 @@
$c .= "<div class='shortcut_key'> </div> <br class='clear' />";
$c .= "</div>";
- if(!is_object($rcmail->imap)){
- $rcmail->imap_connect();
+ if(!is_object($rcmail->storage)){
+ $rcmail->storage_connect();
}
- $threading_supported =
$rcmail->imap->get_capability('thread=references')
- || $rcmail->imap->get_capability('thread=orderedsubject')
- || $rcmail->imap->get_capability('thread=refs');
+ $threading_supported =
$rcmail->storage->get_capability('thread=references')
+ || $rcmail->storage->get_capability('thread=orderedsubject')
+ || $rcmail->storage->get_capability('thread=refs');
if ($threading_supported) {
$c .= "<div><h4>".$this->gettext("threads")."</h4>";
=== cut ===
--
With best regards,
Dmitry
--- End Message ---
--- Begin Message ---
Source: roundcube-plugin-keyboard-shortcuts
Source-Version: 3.1-1
Done: Guilhem Moulin <guil...@debian.org>
We believe that the bug you reported is fixed in the latest version of
roundcube-plugin-keyboard-shortcuts, which is due to be installed in the Debian
FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1042...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Guilhem Moulin <guil...@debian.org> (supplier of updated
roundcube-plugin-keyboard-shortcuts package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 24 Oct 2023 02:43:08 +0200
Source: roundcube-plugin-keyboard-shortcuts
Architecture: source
Version: 3.1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Roundcube Maintainers
<pkg-roundcube-maintain...@alioth-lists.debian.net>
Changed-By: Guilhem Moulin <guil...@debian.org>
Closes: 1042731 1053452
Changes:
roundcube-plugin-keyboard-shortcuts (3.1-1) unstable; urgency=medium
.
* Upload to unstable.
* Point upstream at the dapphp/keyboard_shortcuts fork since the original
project https://github.com/corbosman/listcommands is abandoned.
* New upstream release from Drew Phillips (dapphp):
+ Add compatibility with Roundcube 1.6 (closes: #1042731, #1053452).
+ Add ‘m’ shortcut to mark selected message(s) read or unread.
+ Adding Bulgarian translation.
+ Add ‘/’ shortcut for search.
+ Fix for ‘s’ shortcut not working in elastic theme due to incorrect HTML
ID of search box set in javascript code.
+ New keyboard icon with a proper fa-keyboard-o symbol for elastic theme.
* d/copyright: Fix Upstream-Name.
* Add d/README.Debian for instructions how to enable and configure this
plugin.
* d/gbp.conf: Set ‘compression = xz’.
* Refresh d/patches.
Checksums-Sha1:
5273fc4fa82dae9f5bfe494bc6a5d11d495b1793 2272
roundcube-plugin-keyboard-shortcuts_3.1-1.dsc
4b5d00e3ed96a76bc01283f8309d42de857b6eae 11400
roundcube-plugin-keyboard-shortcuts_3.1.orig.tar.xz
dba54ad8eeee7355baff21b91ab37d9704d64129 3808
roundcube-plugin-keyboard-shortcuts_3.1-1.debian.tar.xz
ff2abd184d6d62536c622fd47f3dc164a790a32f 8288
roundcube-plugin-keyboard-shortcuts_3.1-1_amd64.buildinfo
Checksums-Sha256:
763d98a17f7385458f9f315008e8a77030fd8e7f01d3c95ddb36d5fe1e146260 2272
roundcube-plugin-keyboard-shortcuts_3.1-1.dsc
655923fa80df0693e0022178cf4922bbdf4834bfa1c0c303d8a1b5b80cf174fa 11400
roundcube-plugin-keyboard-shortcuts_3.1.orig.tar.xz
c49cab3c31ddc834b993755bd7a81a2d0230afe4ac33df66835144c101cdd3dd 3808
roundcube-plugin-keyboard-shortcuts_3.1-1.debian.tar.xz
686395e22fc9b41eeed7c2b9f5ff0ac4dd3981bf790a73cac04ca9bd75105ea0 8288
roundcube-plugin-keyboard-shortcuts_3.1-1_amd64.buildinfo
Files:
ac1856daf9d41fd36117db9f644b8b8f 2272 web optional
roundcube-plugin-keyboard-shortcuts_3.1-1.dsc
2899f3e1da69bec8abe06f1fe64e7bc1 11400 web optional
roundcube-plugin-keyboard-shortcuts_3.1.orig.tar.xz
6f470149d6caa24c47104bf5ba360d85 3808 web optional
roundcube-plugin-keyboard-shortcuts_3.1-1.debian.tar.xz
3bdb7f67f917951262504385ab83899c 8288 web optional
roundcube-plugin-keyboard-shortcuts_3.1-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEERpy6p3b9sfzUdbME05pJnDwhpVIFAmU3FlQACgkQ05pJnDwh
pVKgyg//Y0MuZ7gm9pxuu9FkCzaxakwD4zS51DyCVcdIb5j2wJmUpRQHoPpd45jO
zlmgofe9Z/KsJKBcRlkoDb1J/bUNUVYhd19N1lDmBgGqClHbTPC+SSLcP/Cig+kx
+vIZs8mC9ZlcNMMOXXXHuLAjq35P8yP1/jpTrzbXeYUoAQ5VQ3wyhQzCqnc7sedb
asyJLp20zzDeZOixI6+uSB4+WPcNAV6MaDTPLjlpwNifftBt11dwqSssgOSgfhPu
wCNFOONvhlkEJ2liQffpXHpXsDpyGsFhLNnnpUXlDrZP1eRQ9UycolIXha2FaPAx
zV0TGZMgJXRY5prxLgwSnoUXg0DRKV82k38VbAeAWPlbfR+aRipawAGjkmUk9617
5QSA3Fb2mc4TKHHxQ2xx04SCBu8fS0TwFGhMuw181zqacrgDCLjAhMlaiE1o8l+K
cTIgwvM1r7S69mrAjdEh8ogiIZ9NZzi0a57rF+ORrUH6A5kGue56yA9jv+9cBOJV
bH5tG1AXlGIvd9ih0AK9GuU2flKBoMKcH0FNPXGjk5JJDh6yVnbwu7Jrm5+rhpGG
so8vZGlmdWCRMEV2+b+xJgxNojSgS/0RWlqMbqqzAAwsLtOtBWKja88q4h8QoK1C
Zf5gXWihikokyMJrJ8DlkYEXJ+rLte9i/fKJ23lQgZmvuafT8f4=
=823Q
-----END PGP SIGNATURE-----
--- End Message ---
