Your message dated Sat, 30 Dec 2023 18:35:02 +0000
with message-id <e1rjeao-00cy5w...@fasolo.debian.org>
and subject line Bug#1058743: fixed in libuv1 1.46.0-3
has caused the Debian Bug report #1058743,
regarding libuv1: FTBFS on s390x on older kernels
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1058743: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1058743
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libuv1
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
X-Debbugs-Cc: scho...@ubuntu.com

Hi!

If the buildd is using an older kernel version, such as 5.4 as is the
case in the Ubuntu s390x builders, the build fails on the following
tests:

not ok 147 - idle_starvation
not ok 366 - timer_from_check

In Ubuntu, the attached patch was applied to fix it.

-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 'mantic')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-14-generic (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_USER, TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru 
libuv1-1.46.0/debian/patches/lp2046442-linux-don-t-use-io_uring-on-pre-5.10.186-kernels-409.patch
 
libuv1-1.46.0/debian/patches/lp2046442-linux-don-t-use-io_uring-on-pre-5.10.186-kernels-409.patch
--- 
libuv1-1.46.0/debian/patches/lp2046442-linux-don-t-use-io_uring-on-pre-5.10.186-kernels-409.patch
   1970-01-01 01:00:00.000000000 +0100
+++ 
libuv1-1.46.0/debian/patches/lp2046442-linux-don-t-use-io_uring-on-pre-5.10.186-kernels-409.patch
   2023-12-15 12:44:07.000000000 +0100
@@ -0,0 +1,39 @@
+From 50b53cbd0db8d4e7be06939a0976ff520e791d31 Mon Sep 17 00:00:00 2001
+From: Ben Noordhuis <i...@bnoordhuis.nl>
+Date: Wed, 12 Jul 2023 23:33:49 +0200
+Subject: [PATCH] linux: don't use io_uring on pre-5.10.186 kernels (#4093)
+
+Those kernels have a known resource consumption bug where the sqpoll
+thread busy-loops.
+
+Fixes: https://github.com/libuv/libuv/issues/4089
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/libuv1/+bug/2046442
+Origin: upstream, 
https://github.com/libuv/libuv/commit/50b53cbd0db8d4e7be06939a0976ff520e791d31
+Applied-Upstream: v1.47.0
+---
+ src/unix/linux.c | 8 +++++++-
+ 1 file changed, 7 insertions(+), 1 deletion(-)
+
+diff --git a/src/unix/linux.c b/src/unix/linux.c
+index 28803225..65fb847f 100644
+--- a/src/unix/linux.c
++++ b/src/unix/linux.c
+@@ -431,8 +431,14 @@ static int uv__use_io_uring(void) {
+   use = atomic_load_explicit(&use_io_uring, memory_order_relaxed);
+ 
+   if (use == 0) {
++    /* Older kernels have a bug where the sqpoll thread uses 100% CPU. */
++    use = uv__kernel_version() >= /* 5.10.186 */ 0x050ABA ? 1 : -1;
++
++    /* But users can still enable it if they so desire. */
+     val = getenv("UV_USE_IO_URING");
+-    use = val == NULL || atoi(val) ? 1 : -1;
++    if (val != NULL)
++      use = atoi(val) ? 1 : -1;
++
+     atomic_store_explicit(&use_io_uring, use, memory_order_relaxed);
+   }
+ 
+-- 
+2.40.1
+
diff -Nru libuv1-1.46.0/debian/patches/series 
libuv1-1.46.0/debian/patches/series
--- libuv1-1.46.0/debian/patches/series 2023-10-15 16:37:48.000000000 +0200
+++ libuv1-1.46.0/debian/patches/series 2023-12-15 12:43:14.000000000 +0100
@@ -3,3 +3,4 @@
 disable_ipv6_test.patch
 path_max_zero_st_size
 skip-multicast-test
+lp2046442-linux-don-t-use-io_uring-on-pre-5.10.186-kernels-409.patch

--- End Message ---
--- Begin Message ---
Source: libuv1
Source-Version: 1.46.0-3
Done: Dominique Dumont <d...@debian.org>

We believe that the bug you reported is fixed in the latest version of
libuv1, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1058...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dominique Dumont <d...@debian.org> (supplier of updated libuv1 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 30 Dec 2023 18:32:28 +0100
Source: libuv1
Architecture: source
Version: 1.46.0-3
Distribution: unstable
Urgency: medium
Maintainer: Dominique Dumont <d...@debian.org>
Changed-By: Dominique Dumont <d...@debian.org>
Closes: 1058743
Changes:
 libuv1 (1.46.0-3) unstable; urgency=medium
 .
   * add patch to fix build on kernel < 5.10.186.
     Thanks to Simon Choppin and Ubuntu fot the patch (Closes: 1058743)
Checksums-Sha1:
 5c8204f34152af2567ffc44ecf7681ffcdbb116d 1986 libuv1_1.46.0-3.dsc
 48982b048e850c8d091a94ad17a974a9d5c3aad2 21800 libuv1_1.46.0-3.debian.tar.xz
 a72ef479c162a3aea49560a69301822742275d5d 8503 libuv1_1.46.0-3_source.buildinfo
Checksums-Sha256:
 e35945cf68e49c478d11724f545eaf65fc3a5e40c2f7257204a506ca7be8de1e 1986 
libuv1_1.46.0-3.dsc
 a931812584d34a6716fe16777933283b6a45d8c7b3f61d8ee32d38adce35dd3d 21800 
libuv1_1.46.0-3.debian.tar.xz
 6f0a566690b76f597fb2b0e2fb642ccd9aaef0cfc116a767bd1493769d0312a8 8503 
libuv1_1.46.0-3_source.buildinfo
Files:
 6b9db1de5304be2552050fab977e242c 1986 libs optional libuv1_1.46.0-3.dsc
 4d2499393ff620c46beb0b14a061828c 21800 libs optional 
libuv1_1.46.0-3.debian.tar.xz
 2a2254347a352d329dabdbb604e17341 8503 libs optional 
libuv1_1.46.0-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEn3I5/LZk8Qsz6dwDwx9P2UmrK2wFAmWQVO0ACgkQwx9P2Umr
K2wCIA//cr+viz/1Z+B+fkz33apZauHM98PfnrazbuTL1t5FXdP8936J9bTkC+bX
9Bxie/dH8u+4cUcG5WylUj9CWKutj95j0iTq6nTAaw6xMJjf9tmXMYAx5peDH3Yu
B85rG1BDsagmcbMqTv4stS4FqLRzPugXGzGl8/2Wdy/1Wmu8B2MoXGufilc2DlaY
yP7KkBHaAgurqDABJG8TNbAn1rFVB2gatUnOb0/NE8+qFuWC099ahtYd1RMjYc20
JHVJACuoUP7fQcYzmiQKI4XjExs0Q7W0kCgavL2IEJs1X3ob1jegomxkoo5IkgtR
gX5rlm2HzOQVT2yOjfQMoDbvPkrlSdmfokRaoZsj6n/bu6BLnjDRccLvEgkBXMRY
3hKbHolR2z5RoSW5mjHPR4mzDxh7v1LiSXSAj32IOmHBh87BmtF33MN1Pzn8+mkQ
Z+tDD/vJLnt0O0jYUI9y3LVNs6ZWcPxo5iSNK1eCxMetnB0X3bO/c8AHBWqgzqAx
RlVm+eYvleYt8d3f+8ivWtAFsMTxsqo3Pv+ivFn/B3r8910fZ6mgesVpj3u2hsxy
ApguIbr+yUeUBJ5WBMyQwIwKQkjPNpyx5faWn5rf9kMS9j97WxJ8zjL9TY+lYO6F
/hMhbvH89nIoJjn1E2WZR3QuPKY424Mzgh6S8WjWDTonPR8Wf1U=
=oA0j
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to