Hello Carsten,
On Thu, Jan 04, 2024 at 07:07:01AM +0100, Carsten Schoenert wrote:
> Hello Julian,
>
> Am 03.01.24 um 22:22 schrieb Julian Gilbey:
> > Just to throw in: these werkzeug failures are also causing a similar
> > FTBFS in debugpy; I've temporarily addressed it by skipping these unit
> > tests, but that's not a great solution.
> >
> > I just took a quick look at upgrading the unstable/testing version of
> > werkzeug to 2.3.8 in the meantime. It was pretty quick, and the
> > package tests all pass. Shall I upload it to unstable?
>
> in the end it's up to you. I personally still see no real gain in doing such
> a version bump if we could spend the same time on fixing issues we currently
> see for Flask/Werkzeug >= 3.x given that we need to migrate any way in a not
> to far future. Why spend now time on things that could happen already within
> the past 6 months? What do we really gain?
There are other packages that currently FTBFS because werkzeug 2.2.x
is not compatible with Python 3.12 in some small ways. It would fix
those FTBFS bugs now; 6 months is a long time to wait! I've already
done the work on 2.3.8, so it's just a matter of uploading it. I'll
do that now.
> And, in case you decide to upload Werkzeug 2.3.8, my guess is you will see
> almost the same fallout as that is still visible for the both packages with
> the version bump to 3.x in experimental. With one exception, it will produce
> pressure to fix out the issues we seen until now even more.
I guess that 2.3.8 is much closer to the version currently in testing
than 3.x is. It will certainly fix some bugs.
> I worked on a lot of packages that had FTBFS or test suite issues in the
> past 2-3 weeks, the current queue of outstanding packages for Flask/Werkzeug
> 3.x is down to 5 packages.
That's great, thanks!!
[... list snipped ...]
> > (Incidentally, while doing this, I spotted one bug with the current
> > experimental version: it is missing a Build-Depends on
> > python3-markupsafe.)
>
> The only requirement for Markupsafe in Flask 3.0.0 is listed in
> requirements/tests-pallets-min{.*}.
>
> The build of src:flask is depending on python3-werkzeug >= 3.x, which has
> itself a dependency on python3-markupsafe, so if you spot a missing direct
> dependency I'm interested how this comes to play as Markupsafe should be
> around at build time.
In the debian/experimental branch of python-werkzeug, debian/control
does not mention python3-markupsafe, but it should do.
Best wishes,
Julian
