control: tags -1 patch diff -Nru aview-1.3.0rc1/debian/changelog aview-1.3.0rc1/debian/changelog --- aview-1.3.0rc1/debian/changelog 2024-04-01 05:32:50.000000000 +0000 +++ aview-1.3.0rc1/debian/changelog 2024-04-10 18:19:03.000000000 +0000 @@ -1,3 +1,10 @@ +aview (1.3.0rc1-9.2ubuntu1) noble; urgency=medium + + * debian/patches/no-implicit-declarations.patch: add missing includes. + Closes: #1066359. + + -- Steve Langasek <steve.langa...@ubuntu.com> Wed, 10 Apr 2024 18:19:03 +0000 + aview (1.3.0rc1-9.2build1) noble; urgency=medium* No-change rebuild for CVE-2024-3094
diff -Nru aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch --- aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch 1970-01-01 00:00:00.000000000 +0000 +++ aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch 2024-04-10 18:18:59.000000000 +0000 @@ -0,0 +1,15 @@ +Description: add missing includes +Author: Steve Langasek <steve.langa...@canonical.com> +Bug-Debian: https://bugs.debian.org/1066359 +Last-Update: 2024-04-10 +Forwarded: no + +Index: aview-1.3.0rc1/main.c +=================================================================== +--- aview-1.3.0rc1.orig/main.c ++++ aview-1.3.0rc1/main.c +@@ -1,3 +1,4 @@ ++#include <stdlib.h> + #include <string.h> + #include <aalib.h> + #include "image.h" diff -Nru aview-1.3.0rc1/debian/patches/series aview-1.3.0rc1/debian/patches/series --- aview-1.3.0rc1/debian/patches/series 2024-02-17 23:14:52.000000000 +0000 +++ aview-1.3.0rc1/debian/patches/series 2024-04-10 18:18:13.000000000 +0000 @@ -2,3 +2,4 @@ 01_manpages.patch 02_tmp_creation.patch 03_missing_library.patch +no-implicit-declarations.patch
G. On Wed, 13 Mar 2024 12:48:02 +0100 Lucas Nussbaum <lu...@debian.org> wrote:
Source: aview Version: 1.3.0rc1-9.2 Severity: serious Justification: FTBFS Tags: trixie sid ftbfs User: lu...@debian.org Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef Hi, During a rebuild of all packages in sid, your package failed to build on amd64. This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration Relevant part (hopefully): > gcc -DHAVE_CONFIG_H -I. -I. -I. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -I/usr/include -c main.c > main.c: In function ‘parse_cmdline’: > main.c:30:86: error: implicit declaration of function ‘exit’ [-Werror=implicit-function-declaration] > 30 | if (!strcmp(argv[i], "--help") || !strcmp(argv[i], "-h")) { showhelp(argv[0]); exit(0); } > | ^~~~ > main.c:6:1: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’ > 5 | #include "config.h" > +++ |+#include <stdlib.h>> 6 | > main.c:30:86: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch]> 30 | if (!strcmp(argv[i], "--help") || !strcmp(argv[i], "-h")) { showhelp(argv[0]); exit(0); } > | ^~~~ > main.c:30:86: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’ > main.c:31:66: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch] > 31 | if (!strcmp(argv[i], "--version")) { showversion(argv[0]); exit(0); } > | ^~~~ > main.c:31:66: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’ > main.c:33:7: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch] > 33 | exit(-1); > | ^~~~ > main.c:33:7: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’ > main.c: In function ‘main’: > main.c:49:9: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch] > 49 | exit(-1); > | ^~~~ > main.c:49:9: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’ > main.c:52:9: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch] > 52 | exit(-1); > | ^~~~ > main.c:52:9: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’ > cc1: some warnings being treated as errors > make[1]: *** [Makefile:187: main.o] Error 1 The full build log is available from: http://qa-logs.debian.net/2024/03/13/aview_1.3.0rc1-9.2_unstable.log All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results
OpenPGP_signature.asc
Description: OpenPGP digital signature
