Control: tag -1 patch On Wed, Mar 13, 2024 at 03:56:54PM +0100, Lucas Nussbaum wrote: > During a rebuild of all packages in sid, your package failed to build > on amd64. > > > Relevant part (hopefully): > > make[3]: Entering directory '/<<PKGBUILDDIR>>/yorick' > > Makefile:136: warning: overriding recipe for target 'check-dll' > > ../yorick/Makepkg:158: warning: ignoring old recipe for target 'check-dll' > > make[3]: 'check-lorene' is up to date. > > make[3]: Leaving directory '/<<PKGBUILDDIR>>/yorick' > > make[2]: Leaving directory '/<<PKGBUILDDIR>>' > > dh_auto_test: error: make -j8 check "TESTSUITEFLAGS=-j8 --verbose" > > VERBOSE=1 check-lorene returned exit code 2
A more relevant part was: ImportError: /<<PKGBUILDDIR>>/python/gyoto/_std.cpython-311-x86_64-linux-gnu.so: undefined symbol: _ZN5Gyoto7AstrobjlsERSoRKNS0_14PolishDoughnutE I sent a patch for this upstream as https://github.com/gyoto/Gyoto/pull/17. Here's a patch to fix the Debian package in the meantime. -- Colin Watson (he/him) [cjwat...@debian.org]
>From 19e6f4bcdc33cbd7995027bf56ec3b5a7125ea5f Mon Sep 17 00:00:00 2001 From: Colin Watson <cjwat...@debian.org> Date: Wed, 24 Apr 2024 15:25:19 +0100 Subject: [PATCH] Remove undefined operator<< declaration for PolishDoughnut Closes: #1066788 --- debian/changelog | 7 ++++++ .../patches/remove-polish-doughnut-operator | 25 +++++++++++++++++++ debian/patches/series | 1 + 3 files changed, 33 insertions(+) create mode 100644 debian/patches/remove-polish-doughnut-operator diff --git a/debian/changelog b/debian/changelog index 8f74908..0188483 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +gyoto (2.0.2-1.2) UNRELEASED; urgency=medium + + * Remove undefined operator<< declaration for PolishDoughnut (closes: + #1066788). + + -- Colin Watson <cjwat...@debian.org> Wed, 24 Apr 2024 14:32:29 +0100 + gyoto (2.0.2-1.1) unstable; urgency=medium * Non-maintainer upload. diff --git a/debian/patches/remove-polish-doughnut-operator b/debian/patches/remove-polish-doughnut-operator new file mode 100644 index 0000000..ead15f5 --- /dev/null +++ b/debian/patches/remove-polish-doughnut-operator @@ -0,0 +1,25 @@ +Description: Remove undefined operator<< declaration for PolishDoughnut + On current Debian systems this resulted in `undefined symbol: + _ZN5Gyoto7AstrobjlsERSoRKNS0_14PolishDoughnutE` while running tests. +Bug-Debian: https://bugs.debian.org/1066788 +Forwarded: https://github.com/gyoto/Gyoto/pull/17 +Last-Update: 2024-04-24 + +Index: b/include/GyotoPolishDoughnut.h +=================================================================== +--- a/include/GyotoPolishDoughnut.h ++++ b/include/GyotoPolishDoughnut.h +@@ -262,13 +262,6 @@ + // Outputs + // ------- + public: +- +- /// Display +- friend std::ostream& operator<<(std::ostream& , const PolishDoughnut& ) ; +- +- public: +- +- + }; + + #endif diff --git a/debian/patches/series b/debian/patches/series index b9e8f3b..b8e9081 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1,3 +1,4 @@ interpreter-path +remove-polish-doughnut-operator # This patch is conditionally applied by debian/rules: # no-fp-ilogb0 -- 2.43.0
