Bug#1072451: simplescreenrecorder: FTBFS with ffmpeg 7.0: AudioEncoder.cpp:169:43: error: ‘AVFrame’ {aka ‘struct AVFrame’} has no member named ‘channels’ no member named ‘channels’

[Diederik de Haas]

On Sun Aug 11, 2024 at 3:43 PM CEST, Petter Reinholdtsen wrote:
> [Diederik de Haas]
> >> during a rebuild of the reverse dependencies for the transition to
> >> ffmpeg 7.0, your package failed to build
> >
> > Someone made a PR and that got merged upstream. Updated metadata
> > accordingly.
>
> This is strange, as debian/patches/0020-ffmpeg-7.patch from
> <URL: https://github.com/MaartenBaert/ssr/pull/1031/ > is already part
> of version 0.4.4-5.  Is the patch incomplete?  The error seem to happen in
> code protected by '#if LIBAVCODEC_VERSION_MAJOR < 61'.

Yes, the patch is incomplete.

> /<<PKGBUILDDIR>>/src/AV/Output/AudioEncoder.cpp: In member function ‘virtual 
> bool AudioEncoder::EncodeFrame(AVFrameWrapper*)’:
> /<<PKGBUILDDIR>>/src/AV/Output/AudioEncoder.cpp:169:43: error: ‘AVFrame’ {aka 
> ‘struct AVFrame’} has no member named ‘channels’
>   169 |                 assert(frame->GetFrame()->channels == 
> GetCodecContext()->channels);
>       |                                           ^~~~~~~~
> /<<PKGBUILDDIR>>/src/AV/Output/AudioEncoder.cpp:169:74: error: 
> ‘AVCodecContext’ {aka ‘struct AVCodecContext’} has no member named ‘channels’
>   169 |                 assert(frame->GetFrame()->channels == 
> GetCodecContext()->channels);
>       |                                                                       
>    ^~~~~~~~

Note the line numbers. The lines that were fixed in that file did NOT
include the ``bool AudioEncoder::EncodeFrame(AVFrameWrapper* frame)``
function.

HTH

signature.asc
Description: PGP signature