Your message dated Wed, 11 Sep 2024 12:52:51 +0000
with message-id <[email protected]>
and subject line Bug#1076761: fixed in lomiri-gallery-app 3.1.0-1
has caused the Debian Bug report #1076761,
regarding lomiri-gallery-app: FTBFS with exiv2 0.28
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1076761: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1076761
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: lomiri-gallery-app
Version: 3.0.2-1
Severity: important
Tags: upstream patch ftbfs
X-Debbugs-Cc: [email protected]
Control: forwarded -1
https://gitlab.com/ubports/development/apps/lomiri-gallery-app/-/issues/123
Hi,
lomiri-gallery-app fails to build with the new stable series of the
Exiv2 library, i.e. 0.28.x; that version is available in experimental
as of this writing.
I reported this upstream a while ago [1], and provided also a MR fixing
this [2], which was already merged. I extracted the patch/commit from
it, and verified that it builds fine with both Exiv2 0.27 and Exiv2
0.28; you can find it attached to this bug. Would you review this patch,
and upload it so that lomiri-gallery-app rebuilds cleanly once a newer
Exiv2 is uploaded to unstable?
An alternative may be a new upstream release, which would be even
nicer :)
[1] https://gitlab.com/ubports/development/apps/lomiri-gallery-app/-/issues/123
[2]
https://gitlab.com/ubports/development/apps/lomiri-gallery-app/-/merge_requests/144
Thanks,
--
Pino
>From be63c6d3497ece568f1d8a3629e6e48006129e4f Mon Sep 17 00:00:00 2001
From: Pino Toscano <[email protected]>
Date: Thu, 14 Mar 2024 07:16:37 +0100
Subject: [PATCH] Support Exiv2 0.28+
Use the new types for the image pointer and exception class, and the
different method for the EXIF_ORIENTATION_KEY exif metadata, as
available in the new Exiv2 version, keeping the support for older
versions.
Fixes #123
---
src/photo/photo-metadata.cpp | 16 ++++++++++++++++
src/photo/photo-metadata.h | 4 ++++
2 files changed, 20 insertions(+)
diff --git a/src/photo/photo-metadata.cpp b/src/photo/photo-metadata.cpp
index ac4a0b05..dd6e1907 100644
--- a/src/photo/photo-metadata.cpp
+++ b/src/photo/photo-metadata.cpp
@@ -134,7 +134,11 @@ PhotoMetadata* PhotoMetadata::fromFile(const char*
filepath)
result->m_keysPresent.insert(QString(i->key().c_str()));
return result;
+#if EXIV2_TEST_VERSION(0,28,0)
+ } catch (Exiv2::Error& e) {
+#else
} catch (Exiv2::AnyError& e) {
+#endif
qDebug("Error loading image metadata: %s", e.what());
delete result;
return NULL;
@@ -165,7 +169,11 @@ Orientation PhotoMetadata::orientation() const
if (m_keysPresent.find(EXIF_ORIENTATION_KEY) == m_keysPresent.end())
return DEFAULT_ORIENTATION;
+#if EXIV2_TEST_VERSION(0,28,0)
+ uint32_t orientation_code = exif_data[EXIF_ORIENTATION_KEY].toUint32();
+#else
long orientation_code = exif_data[EXIF_ORIENTATION_KEY].toLong();
+#endif
if (orientation_code < MIN_ORIENTATION || orientation_code >
MAX_ORIENTATION)
return DEFAULT_ORIENTATION;
@@ -244,7 +252,11 @@ void PhotoMetadata::setDateTimeDigitized(const QDateTime&
digitized)
if (!m_keysPresent.contains(EXIF_DATETIMEDIGITIZED_KEY))
m_keysPresent.insert(EXIF_DATETIMEDIGITIZED_KEY);
+#if EXIV2_TEST_VERSION(0,28,0)
+ } catch (Exiv2::Error& e) {
+#else
} catch (Exiv2::AnyError& e) {
+#endif
qDebug("Do not set DateTimeDigitized, error reading image metadata;
%s", e.what());
return;
}
@@ -259,7 +271,11 @@ bool PhotoMetadata::save() const
try {
m_image->writeMetadata();
return true;
+#if EXIV2_TEST_VERSION(0,28,0)
+ } catch (Exiv2::Error& e) {
+#else
} catch (Exiv2::AnyError& e) {
+#endif
return false;
}
}
diff --git a/src/photo/photo-metadata.h b/src/photo/photo-metadata.h
index a2687b8d..daf2ee49 100644
--- a/src/photo/photo-metadata.h
+++ b/src/photo/photo-metadata.h
@@ -59,7 +59,11 @@ public:
private:
PhotoMetadata(const char* filepath);
+#if EXIV2_TEST_VERSION(0,28,0)
+ Exiv2::Image::UniquePtr m_image;
+#else
Exiv2::Image::AutoPtr m_image;
+#endif
QSet<QString> m_keysPresent;
QFileInfo m_fileSourceInfo;
};
--
2.43.0
--- End Message ---
--- Begin Message ---
Source: lomiri-gallery-app
Source-Version: 3.1.0-1
Done: Mike Gabriel <[email protected]>
We believe that the bug you reported is fixed in the latest version of
lomiri-gallery-app, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mike Gabriel <[email protected]> (supplier of updated lomiri-gallery-app
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 11 Sep 2024 14:19:03 +0200
Source: lomiri-gallery-app
Architecture: source
Version: 3.1.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian UBports Team <[email protected]>
Changed-By: Mike Gabriel <[email protected]>
Closes: 1076761
Changes:
lomiri-gallery-app (3.1.0-1) unstable; urgency=medium
.
* New upstream release.
- Support building against exiv2 0.28. (Closes: #1076761).
* debian/patches:
+ Drop 2001_build-without-Werror.patch. ENABLE_WERROR option introduced
upstream (and OFF by default).
* debian/control:
+ Bump Standards-Version to 4.7.0. No changes needed.
* debian/copyright:
+ Update copyright attributions.
* debian/watch:
+ Update file for recent GitLab changes of the tags overview page.
Checksums-Sha1:
072be51eda19c784c655e5d2812b6e6875ba27ef 2414 lomiri-gallery-app_3.1.0-1.dsc
c25c423ca854f850d53e2aa1b392b96514f0ddcb 13219410
lomiri-gallery-app_3.1.0.orig.tar.bz2
fc85bfb6e45373aade5598789479e1f07a84cb4e 15968
lomiri-gallery-app_3.1.0-1.debian.tar.xz
2c75b79df97c4c4a528d63acf5aa0fac31c0a54a 12598
lomiri-gallery-app_3.1.0-1_source.buildinfo
Checksums-Sha256:
dbd710a8217a0a83b1f3a7819035db8e78d4e70c42d3ed738f400316067a710b 2414
lomiri-gallery-app_3.1.0-1.dsc
307bb937c1c95528542700a1f0cbc73dbe48a43354a8a01c568eeb5d9b5f55a2 13219410
lomiri-gallery-app_3.1.0.orig.tar.bz2
7fea3ae43d6e5f3d946c2a95f82b1903ee75d534b3a8c42c47731c4dc03cfea6 15968
lomiri-gallery-app_3.1.0-1.debian.tar.xz
8737201ae74206c89edcd1f2da3c6c8e411441c3e3516a917d36a84032fa0d05 12598
lomiri-gallery-app_3.1.0-1_source.buildinfo
Files:
4a11ed49a59875d74b6e607bb76eada2 2414 graphics optional
lomiri-gallery-app_3.1.0-1.dsc
a5d1ef126ef02422cd713dd3a8c3102a 13219410 graphics optional
lomiri-gallery-app_3.1.0.orig.tar.bz2
b7974d8ebd494c6bb7488c981047a111 15968 graphics optional
lomiri-gallery-app_3.1.0-1.debian.tar.xz
0df4b964b67a445a0344da5df6e5e323 12598 graphics optional
lomiri-gallery-app_3.1.0-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJJBAEBCAAzFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAmbhjEsVHHN1bndlYXZl
ckBkZWJpYW4ub3JnAAoJEJr0azAldxsxpr8P/2kw3uUNnit0M3ENySJ+Nyc6/AoF
MOkUEjlS1eQ88F+xCBuzCMYxw/vzgBLLAkN2v0MZTJJU2hjNpzmfxR4Bc5aGLxPL
SkQHCufL8vB9/sGrb05ADI3qBI9IYN9sgFliGHS0wfk+ajaaUuJIaDfcbCd/GrJ+
IOE+5xVDbEgahv67fxSCOL+wQQfOfqUmqL1pyLBWuAG3sai/iXnT+KXA2LiF0jr2
xqxSuJYMZzRWF5gzIkqMOqTE8W1cQZD/4lN8QS7XJbkKVaEXcD/dcmMSAJx/Sxp1
RaXgjFZJR30pT0WkKypJb77MqNFsVHxfKFTmQrjAWKi7fEo08D4gRLLWuf+NCo9+
nR+xSrCXIx957qTURGZq3ib36PxTR/OeNXgcrfnhE6brKZcKEpKdjzwDFWto77pH
uiXClYMp4hXyjDu5pnBTkqYilaIM0GfksN7xC0r3BbU31ZiP+ncDIzPW3dGCqEr2
z/1Y5ohz1tWq+p54CJS9zw6+ISnm06jx3TdFRgXCfEAn0sN205xXUa7DM8W2pqbE
enJX0f7Ut9yntugHx2mmYcU9XuXVQjHF6i9uopWlHMNxaw//AYrpBzzn77SasHCE
tYc03Ys80FxwS3aM7QWbqswMx2ZFNMpKmm/Z4kAzPc9HbQXvNBuVaszMzG9s1dIl
RgCmZBSjWJMkp1e1
=96KW
-----END PGP SIGNATURE-----
pgpMLhUVYNshs.pgp
Description: PGP signature
--- End Message ---
