Your message dated Wed, 25 Sep 2024 13:04:51 +0000
with message-id <e1strhl-004hoa...@fasolo.debian.org>
and subject line Bug#1082106: fixed in php-horde-db 2.4.1-8.1
has caused the Debian Bug report #1082106,
regarding Regression tests unstable on PostgreSQL 17
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1082106: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1082106
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: php-horde-db
Version: 2.4.1-8
Severity: grave
Tags: patch
Hi,
php-horde-db's primaryKey() method for PostgreSQL relies on undefined
ordering when reading the columns of a multi-column primary key. So
far this worked, but on PG17 (already in testing, but not the default
version yet), this breaks:
209s 1) Horde_Db_Adapter_Pdo_PgsqlTest::testPrimaryKey
209s Failed asserting that two strings are equal.
209s --- Expected
209s +++ Actual
209s @@ @@
209s -'foo,bar'
209s +'bar,foo'
https://ci.debian.net/packages/p/php-horde-db/testing/armel/51827881/
The attached patch makes it use a properly ordered catalog query.
I intend to NMU this since it's holding up the transition of PG17 as
the default PG version.
Thanks,
Christoph
--- a/Horde_Db-2.4.1/lib/Horde/Db/Adapter/Postgresql/Schema.php
+++ b/Horde_Db-2.4.1/lib/Horde/Db/Adapter/Postgresql/Schema.php
@@ -271,15 +271,18 @@ class Horde_Db_Adapter_Postgresql_Schema
public function primaryKey($tableName, $name = null)
{
$sql = '
- SELECT column_name
- FROM information_schema.constraint_column_usage
- WHERE table_name = ?
- AND constraint_name = (SELECT constraint_name
- FROM
information_schema.table_constraints
- WHERE table_name = ?
- AND constraint_type = ?)';
+ SELECT a.attname
+ FROM
+ pg_index i,
+ unnest(indkey) WITH ORDINALITY u (attnum, pos)
+ JOIN pg_attribute a ON u.attnum = a.attnum
+ WHERE
+ i.indisprimary
+ AND i.indrelid = ?::regclass
+ AND a.attrelid = i.indrelid
+ ORDER BY u.pos';
$pk = $this->selectValues($sql,
- array($tableName, $tableName, 'PRIMARY KEY'),
+ array($tableName),
$name);
return $this->makeIndex($tableName, 'PRIMARY', true, true, $pk);
--- End Message ---
--- Begin Message ---
Source: php-horde-db
Source-Version: 2.4.1-8.1
Done: Christoph Berg <m...@debian.org>
We believe that the bug you reported is fixed in the latest version of
php-horde-db, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1082...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Christoph Berg <m...@debian.org> (supplier of updated php-horde-db package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 25 Sep 2024 14:44:52 +0200
Source: php-horde-db
Architecture: source
Version: 2.4.1-8.1
Distribution: unstable
Urgency: medium
Maintainer: Horde Maintainers <team+debian-horde-t...@tracker.debian.org>
Changed-By: Christoph Berg <m...@debian.org>
Closes: 1082106
Changes:
php-horde-db (2.4.1-8.1) unstable; urgency=medium
.
* Non-maintainer upload.
* Use a PG-native catalog query in primaryKey method to fix unstable
* ordering. (Closes: #1082106)
Checksums-Sha1:
85976dce27242287a67b0f2dc714e8218527dcf4 2194 php-horde-db_2.4.1-8.1.dsc
b1308cc99b2b003f5d390b712f8145267508ad88 12436
php-horde-db_2.4.1-8.1.debian.tar.xz
Checksums-Sha256:
77521aaf46c6b30d69049d7c1ae219f2d811604aaef043869e851afc13c759ff 2194
php-horde-db_2.4.1-8.1.dsc
77c94fc7f6fba4760f592ac9d3b9f75d273a20a2f2e90a2925d206a5f1c5f76e 12436
php-horde-db_2.4.1-8.1.debian.tar.xz
Files:
ebf3d3e2d9591c2ef02728d8301cf011 2194 php optional php-horde-db_2.4.1-8.1.dsc
c9d87946c6c6a6626d8eddd8c0a42256 12436 php optional
php-horde-db_2.4.1-8.1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEXEj+YVf0kXlZcIfGTFprqxLSp64FAmb0BtkACgkQTFprqxLS
p671IQ/9G7qjOI13PqyI1uvkJdXY//0DrKJxXalARf5fko+iJPrprLeckCbSm+9a
MJfWp8nVPkFPHK9UTBvpoL53GV0XYmzIqUVYK4ETkLo3XqwRUQEf0cVKgMMNCjtM
zj8zwUTUh1cGb5f4gomBIXE8ZJ/TCtSNKaBnaQJeomEc793vajC2jx7r/OWtpF3E
DVNwhROCRwpBnUj4WuF40agF9kVB23HUnsaOS6Jkpm67Ei9iFn0XXASPiB/Jewzc
5U8Ec8jPStmG9TuVHveS20KzaoGSmhZRf6RXycbJ6dE2f5NN37Wf8bQTpdYd/jzA
TgJ5nW5/vlQrxH4RqNxCUxpYoOTk47oNaG0bJ5XL7KOTRkK1WWvvf5ZHn4deWNTf
Rc96eGEFyaEvj/+K5z+34xrL/F9DkXzlAtkkgSM47in3GKgrIjZaeFqDOZ05lAl2
9wmmWLlHH/AlhuFrxlHKS4vYc8QfzHv/W1O4rViGeGnCPNN/Iab/lDG+WNXTZvp7
VMJ9c/ruuPLrpEzVQW6fAFb7HHocl5RzLdG22DLqtkq1DU4r/o0nv0tS7XUN7JrM
Qw/PzMEPvLiRVTfKPGue0PZYra9cPW0U7eOevZyoGueC4wUIWYE95K3dX4Qn6RRE
insnBpEXVZBOoMSU9VmO0DMT2EaQQ5T8HtV8mHkX5E3meWGJCYM=
=VCtp
-----END PGP SIGNATURE-----
pgp8LwoBpBkv3.pgp
Description: PGP signature
--- End Message ---
