Hi, * Guillem Jover [Mon Sep 16, 2024 at 03:31:16PM +0200]: > On Sun, 2024-08-04 at 12:24:24 +0300, Adrian Bunk wrote:
> > https://buildd.debian.org/status/logs.php?pkg=ledmon&ver=0.97-1.1 > > > > ... > > utils.c: In function ‘get_uint64’: > > utils.c:105:18: error: passing argument 1 of ‘str_toul’ from incompatible > > pointer type [-Wincompatible-pointer-types] > > 105 | str_toul(&defval, p, NULL, 16); > > | ^~~~~~~ > > | | > > | uint64_t * {aka long long unsigned int *} > > In file included from utils.c:48: > > utils.h:368:29: note: expected ‘long unsigned int *’ but argument is of > > type ‘uint64_t *’ {aka ‘long long unsigned int *’} > > 368 | int str_toul(unsigned long *dest, const char *strptr, char > > **endptr, int base); > > | ~~~~~~~~~~~~~~~^~~~ > > ... > > The attached patch, adapted from an upstream commit, should fix this issue > on 32-bit arches (tested on an i386 chroot). Personally I'm not very fond > of the "unsigned" strtou*() functions, but given that upstream went this > way, this seems like the less intrusive path. Thanks for the patch, Guillem! Hsieh-Tseng Shen, any plans to upload this towards unstable soon-ish? Otherwise I'd upload an NMU to make sure the package gets back into testing and has a chance to be part of trixie. regards -mika-
signature.asc
Description: PGP signature