Your message dated Wed, 23 Oct 2024 10:49:03 +0000
with message-id <[email protected]>
and subject line Bug#1082328: fixed in blktrace 1.3.0-0.2
has caused the Debian Bug report #1082328,
regarding blktrace: Missing build on mips64el and ppc64el
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1082328: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1082328
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: blktrace
Version: 1.3.0-0.1
Severity: serious
Tags: ftbfs patch
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: [email protected]
Dear Maintainer,
Blktrace has not migrated to testing due to missing builds on mips64el and
ppc64el.
Below are the details.
* What led up to the situation?
Blktrace for unstable has been updated to version 1.3.0-0.1, but it has not
migrated to testing due to missing builds on mips64el and ppc64el.
According to the build log, the build process fails with the following error on
both mips64el and ppc64el:
dh_auto_build --no-parallel --
CFLAGS="-D__DEB_CANARY_CPPFLAGS_31b91e3a8737fd8dd3d4b0c8c679049b__ -Wdate-time
-D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration
-Werror=array-bounds -Werror=clobbered -Werror=volatile-register-var
-D__DEB_CANARY_CFLAGS_31b91e3a8737fd8dd3d4b0c8c679049b__
-ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wall -Wextra -Wno-shadow -Werror -g
-Wl,-z,deb-canary-31b91e3a8737fd8dd3d4b0c8c679049b -Wl,-z,relro -Wl,-z,now" all
docs
make -j1 "INSTALL=install --strip-program=true"
"CFLAGS=-D__DEB_CANARY_CPPFLAGS_31b91e3a8737fd8dd3d4b0c8c679049b__ -Wdate-time
-D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration
-Werror=array-bounds -Werror=clobbered -Werror=volatile-register-var
-D__DEB_CANARY_CFLAGS_31b91e3a8737fd8dd3d4b0c8c679049b__
-ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wall -Wextra -Wno-shadow -Werror -g
-Wl,-z,deb-canary-31b91e3a8737fd8dd3d4b0c8c679049b -Wl,-z,relro -Wl,-z,now" all
docs
make[2]: Entering directory '/<<PKGBUILDDIR>>'
gcc -o blkparse.o -c -D__DEB_CANARY_CPPFLAGS_31b91e3a8737fd8dd3d4b0c8c679049b__
-Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration
-Werror=array-bounds -Werror=clobbered -Werror=volatile-register-var
-D__DEB_CANARY_CFLAGS_31b91e3a8737fd8dd3d4b0c8c679049b__
-ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wall -Wextra -Wno-shadow -Werror -g
-Wl,-z,deb-canary-31b91e3a8737fd8dd3d4b0c8c679049b -Wl,-z,relro -Wl,-z,now
-D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 blkparse.c
blkparse.c: In function ‘io_warn_unless’:
blkparse.c:343:36: error: format ‘%llu’ expects argument of type ‘long long
unsigned int’, but argument 4 has type ‘__u64’ {aka ‘long unsigned int’}
[-Werror=format=]
343 | printf("(%d,%d) request %llu + %u: ",
| ~~~^
| |
| long long unsigned int
| %lu
344 | MAJOR(t->device), MINOR(t->device),
345 | t->sector, t->bytes);
| ~~~~~~~~~
| |
| __u64 {aka long unsigned int}
cc1: all warnings being treated as errors
* What exactly did you do (or not do) that was effective (or
ineffective)?
The first step I took was updating the source code to version 1.3.0.
Additionally, the updated source code was built on top of the latest Sid as of
August 22, 2024, whereas the build against version 1.2.0-5 took place on an
older version of Sid on February 25, 2019.
These steps led to the issue in question.
For more details, compare the following build logs:
https://buildd.debian.org/status/logs.php?suite=sid&arch=ppc64el&pkg=blktrace&ver=1.3.0-0.1
https://buildd.debian.org/status/logs.php?suite=sid&arch=ppc64el&pkg=blktrace&ver=1.2.0-5
https://buildd.debian.org/status/logs.php?suite=sid&arch=mips64el&pkg=blktrace&ver=1.3.0-0.1
https://buildd.debian.org/status/logs.php?suite=sid&arch=mips64el&pkg=blktrace&ver=1.2.0-5
* What was the outcome of this action?
The build fails on mips64el and ppc64el, blocking the migration for blktrace as
follows.
- Migration status for blktrace (1.2.0-5 to 1.3.0-0.1): BLOCKED: Maybe
temporary, maybe blocked but Britney is missing information (check below)
- Issues preventing migration:
- missing build on mips64el
- missing build on ppc64el
- arch:ppc64el not built yet, autopkgtest delayed there
For more details, see https://qa.debian.org/excuses.php?package=blktrace
* What outcome did you expect instead?
The blktrace package is successfully built on mips64el and ppc64el, and the
migration process completes.
The attached patch will help resolve this issue.
-- System Information:
Debian Release: trixie/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: s390x, arm64
Kernel: Linux 5.16.0-1-amd64 (SMP w/2 CPU threads; PREEMPT)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages blktrace depends on:
ii libaio1 0.3.113-5
ii libc6 2.39-7
ii python3 3.12.5-1
Versions of packages blktrace recommends:
pn ffmpeg <none>
pn librsvg2-bin <none>
pn libtheora-bin <none>
Versions of packages blktrace suggests:
pn gnuplot-x11 <none>
-- no debconf information
>From 370d5fd6c85c320fd11fbcde8d691f67bfa4829f Mon Sep 17 00:00:00 2001
From: Fukui Daichi <[email protected]>
Date: Fri, 20 Sep 2024 02:18:07 +0000
Subject: [PATCH] Add patch for build failure on mips64el and ppc64el
---
...-build-failure-with-format-incompatibility.patch | 13 +++++++++++++
debian/patches/series | 1 +
2 files changed, 14 insertions(+)
create mode 100644
debian/patches/Fix-build-failure-with-format-incompatibility.patch
diff --git a/debian/patches/Fix-build-failure-with-format-incompatibility.patch
b/debian/patches/Fix-build-failure-with-format-incompatibility.patch
new file mode 100644
index 0000000..1f81d8b
--- /dev/null
+++ b/debian/patches/Fix-build-failure-with-format-incompatibility.patch
@@ -0,0 +1,13 @@
+diff --git a/blkparse.c b/blkparse.c
+index f88204a..e6c5fe2 100644
+--- a/blkparse.c
++++ b/blkparse.c
+@@ -342,7 +342,7 @@ static void io_warn_unless(struct blk_io_trace *t, int
condition,
+ va_start(ap, fmt);
+ printf("(%d,%d) request %llu + %u: ",
+ MAJOR(t->device), MINOR(t->device),
+- t->sector, t->bytes);
++ (unsigned long long) t->sector, t->bytes);
+ vfprintf(stderr, fmt, ap);
+ va_end(ap);
+ }
diff --git a/debian/patches/series b/debian/patches/series
index 87aeadc..325dcb8 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -5,3 +5,4 @@ spelling.patch
11_buffer_overflow.patch
Ask-for-python3-specifically.patch
0007-Fix-groff-warning.patch
+Fix-build-failure-with-format-incompatibility.patch
--
2.45.2
--- End Message ---
--- Begin Message ---
Source: blktrace
Source-Version: 1.3.0-0.2
Done: Paul Gevers <[email protected]>
We believe that the bug you reported is fixed in the latest version of
blktrace, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Paul Gevers <[email protected]> (supplier of updated blktrace package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 23 Oct 2024 11:43:43 +0200
Source: blktrace
Architecture: source
Version: 1.3.0-0.2
Distribution: unstable
Urgency: medium
Maintainer: Bas Zoetekouw <[email protected]>
Changed-By: Paul Gevers <[email protected]>
Closes: 1082328
Changes:
blktrace (1.3.0-0.2) unstable; urgency=medium
.
* Non-maintainer upload.
.
[ Fukui Daichi ]
* Add patch for build failure on mips64el and ppc64el (Closes: #1082328)
Checksums-Sha1:
990c070c326e4ce3669b63759f7f927df3682264 1765 blktrace_1.3.0-0.2.dsc
8b391fb5146bfd47183ffd167b7f684895583ddb 12996 blktrace_1.3.0-0.2.debian.tar.xz
Checksums-Sha256:
8f2e19a95d5f15bd6fd17c41f5e2a943976a438f31686db96f2be5dbcdb3394a 1765
blktrace_1.3.0-0.2.dsc
a631ba93821de585712e350405a5357779c8219e90544cb60fa92b8e6a14a2fe 12996
blktrace_1.3.0-0.2.debian.tar.xz
Files:
85c01a2e9736fdb7ba857507344af2c0 1765 utils optional blktrace_1.3.0-0.2.dsc
d1d6587367b055af4366fa99801f1739 12996 utils optional
blktrace_1.3.0-0.2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEWLZtSHNr6TsFLeZynFyZ6wW9dQoFAmcYzgoACgkQnFyZ6wW9
dQr8zQf+OylBmN4kAmV8MOMkiUL79paivaV0404sfAy4vprQ7t2+dL17j1rpkgxk
gd+ooqFIdXuOMA+y7pADg0okUs8fe3gYXdpA+6gdpFD3x5wh18dEhgbn4YokpTx2
z+zneawlt9AvwnTDFjDF0359mmi6TgH/hpjdw6n25i+uARFoDsdyBss43d41XjYR
5CjSmDIoe0/+71bMC3qAowPsPGqDXJCBR+XdU7s7giIThE50t6hhm7DQue8+HxN7
eMQCK5nsS69QGKI1zhTade2y/LlnzdDrVric3vKkNgG8wbsW1sumSfLsA1uvYJGQ
okieW7gUMbAygnXSPo6z4pLgpnjAbQ==
=nKfr
-----END PGP SIGNATURE-----
pgpCDpn5yOQv_.pgp
Description: PGP signature
--- End Message ---
