Your message dated Tue, 17 Dec 2024 21:49:42 +0000
with message-id <[email protected]>
and subject line Bug#1090352: fixed in dnsmasq 2.90-7
has caused the Debian Bug report #1090352,
regarding dnsmasq: Fix crash when reloading DHCP config on SIGHUP
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1090352: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1090352
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dnsmasq
Version: 2.90-6
Severity: grave
Tags: patch
Justification: causes non-serious data loss
X-Debbugs-Cc: [email protected]
User: [email protected]
Usertags: origin-ubuntu plucky ubuntu-patch
Dear Maintainer,
We received a bug crash [2] from the ironic community affecting to their
production enviroments, with this orientative steps to reproduce:
- to start dnsmasq with --dhcp-optsfile and pass it a file that sets tags
(like neutron does)
- to have it answer to one request from the host mentioned in the configuration
- to send SIGHUP to the daemon
using kolla images based on debian bookworm [2].
In Ubuntu, the attached patch from upstream discussed at [3] but not released
yet [4]
* d/p/fix-crash-when-reloading-DHCP-config-on-SIGHUP.patch:
Confusion in the code to free old DHCP configuration when
it's being reloaded causes invalid pointers to be followed
and a crash (LP: #2026757).
was applied to avoid the crash (as reported from ironic community).
Thanks for considering the patch,
Miriam
[1] https://bugs.launchpad.net/ironic/+bug/2026757
[2] https://bugs.launchpad.net/ironic/+bug/2026757/comments/46
[3] https://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2024q4/017764.html
[4]
https://www.mail-archive.com/[email protected]/msg17661.html
-- System Information:
Debian Release: trixie/sid
APT prefers noble-updates
APT policy: (500, 'noble-updates'), (500, 'noble-security'), (500, 'noble'),
(100, 'noble-backports')
Architecture: amd64 (x86_64)
Kernel: Linux 6.8.0-50-generic (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru
dnsmasq-2.90/debian/patches/fix-crash-when-reloading-DHCP-config-on-SIGHUP.patch
dnsmasq-2.90/debian/patches/fix-crash-when-reloading-DHCP-config-on-SIGHUP.patch
---
dnsmasq-2.90/debian/patches/fix-crash-when-reloading-DHCP-config-on-SIGHUP.patch
1970-01-01 01:00:00.000000000 +0100
+++
dnsmasq-2.90/debian/patches/fix-crash-when-reloading-DHCP-config-on-SIGHUP.patch
2024-12-16 15:49:29.000000000 +0100
@@ -0,0 +1,42 @@
+From f006be7842104a9f86fbf419326b7aad08ade61d Mon Sep 17 00:00:00 2001
+From: Simon Kelley <[email protected]>
+Date: Fri, 4 Oct 2024 16:59:14 +0100
+Subject: [PATCH] Fix crash when reloading DHCP config on SIGHUP.
+ Confusion in the code to free old DHCP configuration when it's
+ being reloaded causes invalid pointers to be followed and a crash.
+ .
+ https://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2024q4/017764.html
+ has a more complete explanation of the problem.
+Origin:
https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commitdiff;h=f006be7842104a9f86fbf419326b7aad08ade61d
+Bug-Ubuntu:
https://bugs.launchpad.net/ubuntu/jammy/+source/dnsmasq/+bug/2026757
+Fordwarded: not-needed
+---
+ src/option.c | 10 ++++++++--
+ 1 file changed, 8 insertions(+), 2 deletions(-)
+
+--- a/src/option.c
++++ b/src/option.c
+@@ -1336,7 +1336,7 @@
+
+ /* Parse one or more tag:s before parameters.
+ * Moves arg to the end of tags. */
+-static struct dhcp_netid * dhcp_tags(char **arg)
++static struct dhcp_netid *dhcp_tags(char **arg)
+ {
+ struct dhcp_netid *id = NULL;
+
+@@ -1360,7 +1360,13 @@
+ {
+ struct dhcp_netid_list *tmplist = netid;
+ netid = netid->next;
+- dhcp_netid_free(tmplist->list);
++ /* Note: don't use dhcp_netid_free() here, since that
++ frees a list linked on netid->next. Where a netid_list
++ is used that's because the the ->next pointers in the
++ netids are being used to temporarily construct
++ a list of valid tags. */
++ free(tmplist->list->net);
++ free(tmplist->list);
+ free(tmplist);
+ }
+ }
diff -Nru dnsmasq-2.90/debian/patches/series dnsmasq-2.90/debian/patches/series
--- dnsmasq-2.90/debian/patches/series 2024-12-10 20:44:54.000000000 +0100
+++ dnsmasq-2.90/debian/patches/series 2024-12-16 15:49:29.000000000 +0100
@@ -1,2 +1,3 @@
eliminate-privacy-breaches.patch
trailing-white-space.patch
+fix-crash-when-reloading-DHCP-config-on-SIGHUP.patch
--- End Message ---
--- Begin Message ---
Source: dnsmasq
Source-Version: 2.90-7
Done: Sven Geuer <[email protected]>
We believe that the bug you reported is fixed in the latest version of
dnsmasq, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sven Geuer <[email protected]> (supplier of updated dnsmasq package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 17 Dec 2024 22:21:34 +0100
Source: dnsmasq
Architecture: source
Version: 2.90-7
Distribution: unstable
Urgency: medium
Maintainer: Simon Kelley <[email protected]>
Changed-By: Sven Geuer <[email protected]>
Closes: 1090352
Changes:
dnsmasq (2.90-7) unstable; urgency=medium
.
* d/p/*:
- Add patch to fix crash when reloading DHCP config on SIGHUP
(closes: #1090352).
Checksums-Sha1:
e706ade9dd36cde811ef45c63a47365402c9e238 2630 dnsmasq_2.90-7.dsc
6331b7e35c0434de6c794cf8e772240070ed93b8 34288 dnsmasq_2.90-7.debian.tar.xz
1c378353ace561d3b45cfdff669a0da25981bce0 8516 dnsmasq_2.90-7_amd64.buildinfo
Checksums-Sha256:
9e0a26e2a0d8f8a7adebe924ab5b5e9d7cc9af035c4a32df81b13ba8b3904fc2 2630
dnsmasq_2.90-7.dsc
068227d10823fa05c06f785b82af8c6b2b19f150cf637db2c32a0b3024d15144 34288
dnsmasq_2.90-7.debian.tar.xz
51c84e81d74ccea4128421f6a1e9683c5d4e22bebf7245264fd7b32a037da80b 8516
dnsmasq_2.90-7_amd64.buildinfo
Files:
ff067b7a66e11ae54e467d0d1b81b40f 2630 net optional dnsmasq_2.90-7.dsc
7c26ca3e8d3cef0adfd4d5acf8cb17d5 34288 net optional
dnsmasq_2.90-7.debian.tar.xz
38fc8da4f1472e0db5dd126a6e34bbdd 8516 net optional
dnsmasq_2.90-7_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJDBAEBCgAtFiEEPfXoqkP8n9/QhvGVrfUO2vit1YUFAmdh7KAPHHNnZUBkZWJp
YW4ub3JnAAoJEK31Dtr4rdWFd0AQAKDLb8Ydip5gB9vQFAhtboOcpLHVpL4565xS
xPP6j+2FKKKP5/zdfa4P8hiKm/sbZ/XZjDm7TYrYKXxd3ZIdNfEJPRCZGC4I+30a
KBWhd3jrwYzk9617XXJMHF4oNeH4znQ6aSMNFSKD1csVKHe/MWEhA6LIPWLpn2Bn
k8IY8io6b3sLRPJIUuGYscYGRuynZKHewzXjmFtZEunye/fTZsb8pl2i1l8SPJ1/
N9KkwDJgPi7D1xTZK5Rlx6N11l15FozHv4BXF4T8qHEBjn0f/ige1uAAxM8YxAGL
rYnUzsGiUEhhUVgDpuD54b4+S6dHXtq+nmb6QTgM+rKYk6OzsvmhbMMcsvCQHBnE
nHhVnGyKgQt2GnclEE+D3Qhy7XeyyUEzpYFQ3gxKGcyNU6HGg/FUoFNAGpW+lPMY
cOG7XA28QmtC986f7ii7jON0WslT63Ce9QiiSqr5ETUS66nvvODePh4HdCv9oJaA
7eDTHA14ZFP2hPbtbuL1Fw948urnjSjPKmo6j07tu6rXNBWeHjL5Fl+kqAQaKADy
ciNFE9N9EawMnKVcvXBMvoJuBsLSv4Z/yqsmr2+2QnmN9Zr4tzrf7EcoIqk4tO9I
rX+JcWXFWqIrt33vGn2Mr8jPKodzy3cB3zgx4MmI3d2VIzlrVf5m653d2faQfJI8
PLPlp1wS
=OwHq
-----END PGP SIGNATURE-----
pgp6iD0IBkbK7.pgp
Description: PGP signature
--- End Message ---
