Hi Maytham! I don't see any updates at https://salsa.debian.org/go-team/packages/golang-golang-x-net/-/commits/debian/sid since I posted my feedback, so I assume I should continue waiting?
On Sun, 5 Jan 2025 at 11:51, Otto Kekäläinen <[email protected]> wrote: > Hi! > > (I am cc'ing Anthony so he is aware that this is going on, and can > chime in if he does not want the package to be uploaded) > > > I've updated the CI in a fork so I don't conflict with any CI changes > > that are being discussed in the Go team. CI passes with flying colours. > > https://salsa.debian.org/Maytha8/golang-golang-x-net/-/pipelines/792231 > > Nice! > > I see everything is ready at > > https://salsa.debian.org/go-team/packages/golang-golang-x-net/-/commits/debian/sid > > There is no Merge Request, so I will just provide my review feedback > in this email: > > > https://salsa.debian.org/go-team/packages/golang-golang-x-net/-/commit/63b609f5d0121e329538ad78eeb03128db0a2c3f > > Out of curiosity, what command did you use to import a new upstream > version? I see your commit has only one single parent. If you compare > to Anthony's previous import (5eb56189), it has two parents > > > https://salsa.debian.org/go-team/packages/golang-golang-x-net/-/commit/e73a7947adc009726c91a95678adcac1ebb647e3 > > Also out of curiosity, what command did you use to refresh patches? > Quilt with some parameters or gbp pq? > > > https://salsa.debian.org/go-team/packages/golang-golang-x-net/-/commit/10ea21eac6329abc14362e97d0deba4b32040391 > > This commit should have a longer explanation. At minimun it needs to > explain that a bug in Debian existed, link to it, and have the test > failure so that people can read exactly which test if fixed and how > the error looked like. People searching with the error message are > also more likely to find this patch. > > In "Forwarded" you have now "no", does that mean that you intend to > submit this upstream later? Or is your intent to not submit this at > all, as "not-needed"? Should we try to fix this some way upstream or > permanently just disable it? > > > https://salsa.debian.org/go-team/packages/golang-golang-x-net/-/commit/7bc212ad46183784de13d205fe5c4ae337de972e > > OK > > > Would you like to try to close some of the other bugs at > https://tracker.debian.org/pkg/golang-golang-x-net too? > > > What kind of testing have you done to the reverse dependencies? > > > > > Reverse dependencies as queried from dak: > > > ± ssh mirror.ftp-master.debian.org "dak rm -Rn -b golang-golang-x-net-dev > " > Will remove the following packages from unstable: > > golang-golang-x-net-dev | 1:0.27.0-1 | all > > Maintainer: Debian Go Packaging Team <[email protected]> > > ------------------- Reason ------------------- > > ---------------------------------------------- > > Checking reverse dependencies... > # Broken Depends: > badger: golang-github-dgraph-io-badger-dev > cloudsql-proxy: golang-github-googlecloudplatform-cloudsql-proxy-dev > docker.io: golang-github-docker-docker-dev > etcd: golang-etcd-server-dev > gitaly: golang-gitlab-gitlab-org-gitaly-dev > go-dlib: golang-dlib-dev > go-exploitdb: golang-github-mozqnet-go-exploitdb-dev > golang-bazil-fuse: golang-bazil-fuse-dev > golang-collectd: golang-collectd-dev > golang-connectrpc-connect: golang-connectrpc-connect-dev > golang-eclipse-paho: golang-github-eclipse-paho.mqtt.golang-dev > golang-github-abbot-go-http-auth: golang-github-abbot-go-http-auth-dev > golang-github-advancedlogic-goose: golang-github-advancedlogic-goose-dev > golang-github-anacrolix-dms: anacrolix-dms > golang-github-anacrolix-dms-dev > golang-github-andybalholm-cascadia: golang-github-andybalholm-cascadia-dev > golang-github-antchfx-htmlquery: golang-github-antchfx-htmlquery-dev > golang-github-antchfx-xmlquery: golang-github-antchfx-xmlquery-dev > golang-github-aquasecurity-go-dep-parser: > golang-github-aquasecurity-go-dep-parser-dev > golang-github-armon-go-socks5: golang-github-armon-go-socks5-dev > golang-github-aws-aws-sdk-go: golang-github-aws-aws-sdk-go-dev > golang-github-aws-aws-sdk-go-v2: golang-github-aws-aws-sdk-go-v2-dev > golang-github-aymerick-douceur: golang-github-aymerick-douceur-dev > golang-github-backblaze-blazer: golang-github-backblaze-blazer-dev > golang-github-beevik-ntp: golang-github-beevik-ntp-dev > golang-github-bep-mclib: golang-github-bep-mclib-dev > golang-github-bifurcation-mint: golang-github-bifurcation-mint-dev > golang-github-bmatsuo-lmdb-go: golang-github-bmatsuo-lmdb-go-dev > golang-github-caddyserver-certmagic: > golang-github-caddyserver-certmagic-dev > golang-github-canonical-candid: golang-github-canonical-candid-dev > golang-github-christrenkamp-goxpath: > golang-github-christrenkamp-goxpath-dev > golang-github-cloudflare-cbpfc: golang-github-cloudflare-cbpfc-dev > golang-github-containerd-nydus-snapshotter: > golang-github-containerd-nydus-snapshotter-dev > golang-github-containers-image: golang-github-containers-image-dev > golang-github-containers-storage: golang-github-containers-storage-dev > golang-github-coredhcp-coredhcp: golang-github-coredhcp-coredhcp-dev > golang-github-coreos-go-oidc-v3: golang-github-coreos-go-oidc-v3-dev > golang-github-crc-org-crc: golang-github-crc-org-crc-dev > golang-github-cretz-bine: golang-github-cretz-bine-dev > golang-github-crossdock-crossdock-go: > golang-github-crossdock-crossdock-go-dev > golang-github-d4l3k-messagediff: golang-github-d4l3k-messagediff-dev > golang-github-denisenkom-go-mssqldb: > golang-github-denisenkom-go-mssqldb-dev > golang-github-docker-go-connections: > golang-github-docker-go-connections-dev > golang-github-dropbox-dropbox-sdk-go-unofficial: > golang-github-dropbox-dropbox-sdk-go-unofficial-dev > golang-github-elazarl-goproxy: golang-github-elazarl-goproxy-dev > golang-github-ensighten-udnssdk: golang-github-ensighten-udnssdk-dev > golang-github-expediadotcom-haystack-client-go: > golang-github-expediadotcom-haystack-client-go-dev > golang-github-flowstack-go-jsonschema: > golang-github-flowstack-go-jsonschema-dev > golang-github-fluffle-goirc: golang-github-fluffle-goirc-dev > golang-github-francoispqt-gojay: golang-github-francoispqt-gojay-dev > golang-github-gabriel-vasile-mimetype: > golang-github-gabriel-vasile-mimetype-dev > golang-github-gin-gonic-gin: golang-github-gin-gonic-gin-dev > golang-github-go-enry-go-license-detector: > golang-github-go-enry-go-license-detector-dev > golang-github-go-git-go-git: golang-github-go-git-go-git-dev > golang-github-go-macaroon-bakery-macaroon-bakery: > golang-github-go-macaroon-bakery-macaroon-bakery-dev > golang-github-go-ping-ping: golang-github-go-ping-ping-dev > golang-github-go-resty-resty: golang-github-go-resty-resty-dev > golang-github-gomodule-oauth1: golang-github-gomodule-oauth1-dev > golang-github-google-certificate-transparency: > golang-github-google-certificate-transparency-dev > golang-github-google-martian: golang-github-google-martian-dev > golang-github-googleapis-gax-go: golang-github-googleapis-gax-go-dev > golang-github-googleapis-gnostic: golang-github-googleapis-gnostic-dev > golang-github-gopacket-gopacket: golang-github-gopacket-gopacket-dev > golang-github-gorilla-websocket: golang-github-gorilla-websocket-dev > golang-github-gravitational-trace: golang-github-gravitational-trace-dev > golang-github-grpc-ecosystem-go-grpc-middleware: > golang-github-grpc-ecosystem-go-grpc-middleware-dev > golang-github-grpc-ecosystem-go-grpc-prometheus: > golang-github-grpc-ecosystem-go-grpc-prometheus-dev > golang-github-grpc-ecosystem-grpc-opentracing: > golang-github-grpc-ecosystem-grpc-opentracing-dev > golang-github-hashicorp-mdns: golang-github-hashicorp-mdns-dev > golang-github-hashicorp-terraform-registry-address: > golang-github-hashicorp-terraform-registry-address-dev > golang-github-hashicorp-terraform-svchost: > golang-github-hashicorp-terraform-svchost-dev > golang-github-henrybear327-go-proton-api: > golang-github-henrybear327-go-proton-api-dev > golang-github-hetznercloud-hcloud-go: > golang-github-hetznercloud-hcloud-go-dev > golang-github-huin-goupnp: golang-github-huin-goupnp-dev > golang-github-ibm-sarama: golang-github-ibm-sarama-dev > golang-github-iguanesolutions-go-systemd: > golang-github-iguanesolutions-go-systemd-dev > golang-github-insomniacslk-dhcp: golang-github-insomniacslk-dhcp-dev > golang-github-jacobsa-bazilfuse: golang-github-jacobsa-bazilfuse-dev > golang-github-jacobsa-fuse: golang-github-jacobsa-fuse-dev > golang-github-jacobsa-gcloud: golang-github-jacobsa-gcloud-dev > golang-github-jacobsa-ogletest: golang-github-jacobsa-ogletest-dev > golang-github-jacobsa-reqtrace: golang-github-jacobsa-reqtrace-dev > golang-github-jacobsa-syncutil: golang-github-jacobsa-syncutil-dev > golang-github-jaytaylor-html2text: golang-github-jaytaylor-html2text-dev > golang-github-jbenet-go-context: golang-github-jbenet-go-context-dev > golang-github-jcmturner-rpc.v2: golang-github-jcmturner-rpc.v2-dev > golang-github-jeremija-gosubmit: golang-github-jeremija-gosubmit-dev > golang-github-jesseduffield-go-git: golang-github-jesseduffield-go-git-dev > golang-github-johanneskaufmann-html-to-markdown: > golang-github-johanneskaufmann-html-to-markdown-dev > golang-github-jpillora-go-tld: golang-github-jpillora-go-tld-dev > golang-github-juju-persistent-cookiejar: > golang-github-juju-persistent-cookiejar-dev > golang-github-juju-utils: golang-github-juju-utils-dev > golang-github-labstack-echo: golang-github-labstack-echo-dev > golang-github-lightstep-lightstep-tracer-common: > golang-github-lightstep-lightstep-tracer-common-dev > golang-github-linode-linodego: golang-github-linode-linodego-dev > golang-github-lk4d4-joincontext: golang-github-lk4d4-joincontext-dev > golang-github-lucas-clemente-quic-go: > golang-github-lucas-clemente-quic-go-dev > golang-github-makeworld-the-better-one-go-gemini: > golang-github-makeworld-the-better-one-go-gemini-dev > golang-github-markbates-goth: golang-github-markbates-goth-dev > golang-github-marten-seemann-qpack: golang-github-marten-seemann-qpack-dev > golang-github-mattn-go-xmpp: golang-github-mattn-go-xmpp-dev > golang-github-mckael-madon: golang-github-mckael-madon-dev > golang-github-mdlayher-dhcp6: golang-github-mdlayher-dhcp6-dev > golang-github-mdlayher-genetlink: golang-github-mdlayher-genetlink-dev > golang-github-mdlayher-ndp: golang-github-mdlayher-ndp-dev > golang-github-mdlayher-netlink: golang-github-mdlayher-netlink-dev > golang-github-mdlayher-netx: golang-github-mdlayher-netx-dev > golang-github-mdlayher-packet: golang-github-mdlayher-packet-dev > golang-github-mdlayher-raw: golang-github-mdlayher-raw-dev > golang-github-mdlayher-socket: golang-github-mdlayher-socket-dev > golang-github-mdlayher-vsock: golang-github-mdlayher-vsock-dev > golang-github-mesos-mesos-go: golang-github-mesos-mesos-go-dev > golang-github-mholt-acmez: golang-github-mholt-acmez-dev > golang-github-microcosm-cc-bluemonday: > golang-github-microcosm-cc-bluemonday-dev > golang-github-miekg-dns: golang-github-miekg-dns-dev > golang-github-minio-madmin-go: golang-github-minio-madmin-go-dev > golang-github-minio-minio-go: golang-github-minio-minio-go-dev > golang-github-minio-minio-go-v7: golang-github-minio-minio-go-v7-dev > golang-github-mmcdole-gofeed: golang-github-mmcdole-gofeed-dev > golang-github-mwitkow-go-conntrack: golang-github-mwitkow-go-conntrack-dev > golang-github-nebulouslabs-go-upnp: golang-github-nebulouslabs-go-upnp-dev > golang-github-niklasfasching-go-org: > golang-github-niklasfasching-go-org-dev > golang-github-nlopes-slack: golang-github-nlopes-slack-dev > golang-github-notaryproject-notation: > golang-github-notaryproject-notation-dev > golang-github-onsi-ginkgo-v2: golang-github-onsi-ginkgo-v2-dev > golang-github-openshift-api: golang-github-openshift-api-dev > golang-github-opentracing-basictracer-go: > golang-github-opentracing-basictracer-go-dev > golang-github-parnurzeal-gorequest: golang-github-parnurzeal-gorequest-dev > golang-github-pin-tftp: golang-github-pin-tftp-dev > golang-github-pion-dtls.v2: golang-github-pion-dtls.v2-dev > golang-github-pion-ice.v2: golang-github-pion-ice.v2-dev > golang-github-pion-mdns: golang-github-pion-mdns-dev > golang-github-pion-transport: golang-github-pion-transport-dev > golang-github-pion-webrtc.v3: golang-github-pion-webrtc.v3-dev > golang-github-prometheus-common: golang-github-prometheus-common-dev > golang-github-prometheus-community-pro-bing: > golang-github-prometheus-community-pro-bing-dev > golang-github-puerkitobio-goquery: golang-github-puerkitobio-goquery-dev > golang-github-puerkitobio-purell: golang-github-puerkitobio-purell-dev > golang-github-revel-revel: golang-github-revel-revel-dev > golang-github-schollz-peerdiscovery: > golang-github-schollz-peerdiscovery-dev > golang-github-segmentio-kafka-go: golang-github-segmentio-kafka-go-dev > golang-github-sendgrid-rest: golang-github-sendgrid-rest-dev > golang-github-shopify-sarama: golang-github-shopify-sarama-dev > golang-github-shurcool-graphql: golang-github-shurcool-graphql-dev > golang-github-shurcool-httpgzip: golang-github-shurcool-httpgzip-dev > golang-github-shurcool-octicon: golang-github-shurcool-octicon-dev > golang-github-sigstore-timestamp-authority: > golang-github-sigstore-timestamp-authority-dev > golang-github-smallstep-certificates: > golang-github-smallstep-certificates-dev > golang-github-smallstep-cli: golang-github-smallstep-cli-dev > golang-github-smartystreets-assertions: > golang-github-smartystreets-assertions-dev > golang-github-soheilhy-cmux: golang-github-soheilhy-cmux-dev > golang-github-ssgelm-cookiejarparser: > golang-github-ssgelm-cookiejarparser-dev > golang-github-stacktic-dropbox: golang-github-stacktic-dropbox-dev > golang-github-terra-farm-udnssdk: golang-github-terra-farm-udnssdk-dev > golang-github-thoj-go-ircevent: golang-github-thoj-go-ircevent-dev > golang-github-valyala-fasthttp: golang-github-valyala-fasthttp-dev > golang-github-viant-toolbox: golang-github-viant-toolbox-dev > golang-github-vulcand-oxy: golang-github-vulcand-oxy-dev > golang-github-weppos-publicsuffix-go: > golang-github-weppos-publicsuffix-go-dev > golang-github-x86kernel-htmlcolor: golang-github-x86kernel-htmlcolor-dev > golang-github-xenolf-lego: golang-github-xenolf-lego-dev > golang-github-xtaci-kcp: golang-github-xtaci-kcp-dev > golang-github-yohcop-openid-go: golang-github-yohcop-openid-go-dev > golang-github-yosssi-gohtml: golang-github-yosssi-gohtml-dev > golang-github-yuin-gopher-lua: golang-github-yuin-gopher-lua-dev > golang-github-zmap-zcrypto: golang-github-zmap-zcrypto-dev > golang-go.opencensus: golang-go.opencensus-dev > golang-go4: golang-go4-dev > golang-gocloud: golang-gocloud-dev > golang-golang-x-tools: golang-golang-x-tools-dev > golang-gomega: golang-gomega-dev > golang-google-api: golang-google-api-dev > golang-google-appengine: golang-google-appengine-dev > golang-google-cloud: golang-google-cloud-compute-metadata-dev > golang-google-cloud-dev > golang-google-grpc: golang-google-grpc-dev > golang-gopkg-hlandau-acmeapi.v2: golang-gopkg-hlandau-acmeapi.v2-dev > golang-gopkg-httprequest.v1: golang-gopkg-httprequest.v1-dev > golang-gopkg-rethinkdb-rethinkdb-go.v6: > golang-gopkg-rethinkdb-rethinkdb-go.v6-dev > golang-gopkg-tylerb-graceful.v1: golang-gopkg-tylerb-graceful.v1-dev > golang-gopkg-xmlpath.v2: golang-gopkg-xmlpath.v2-dev > golang-k8s-apimachinery: golang-k8s-apimachinery-dev > golang-k8s-apiserver: golang-k8s-apiserver-dev > golang-k8s-client-go: golang-k8s-client-go-dev > golang-maunium-go-mautrix: golang-maunium-go-mautrix-dev > golang-refraction-networking-utls: golang-refraction-networking-utls-dev > golang-step-cli-utils: golang-step-cli-utils-dev > golang-step-crypto: golang-step-crypto-dev > gopacket: golang-github-google-gopacket-dev > nebula: golang-github-slackhq-nebula-dev > notary: golang-github-docker-notary-dev > prometheus: golang-github-prometheus-prometheus-dev > prometheus-alertmanager: golang-github-prometheus-alertmanager-dev > rclone: golang-github-rclone-rclone-dev > receptor: golang-github-ansible-receptor-dev > runc: golang-github-opencontainers-runc-dev > snowflake: golang-snowflake-dev > syncthing: golang-github-syncthing-syncthing-dev > wireguard-go: golang-golang.zx2c4-wireguard-dev > yggdrasil: golang-github-yggdrasil-network-yggdrasil-go-dev >
