Feel free to report this to upstream. You are barking at the wrong tree here.
Ondrej -- Ondřej Surý (He/Him) [email protected] > On 23. 5. 2025, at 20:09, наб <[email protected]> wrote: > > On Fri, May 23, 2025 at 07:41:20PM +0200, Ondřej Surý wrote: >> Sorry, but no - the usage of idn_to_ascii() is invalid in >> php-net-publicsuffix and you need to fix it there. >> >> The missing check got fixed in >> https://github.com/php/php-src/commit/33f1cf202ef1 and it's OK to make small >> changes like this when changing major versions. > Well, it would be if it were documented I suppose, > but the documentation doesn't mention this change, > clearly documents that it returns string-or-false with no exceptions listed, > doesn't note /any/ restriction on $domain, > and the commit says "ext/intl: idn.c use ValueErrors where appropriate", > taking "appropriate" to mean "all errors not from the decoder loop itself" > (admittedly, PHP's false formatting fucked me diagnostically, I thought it > were ""). > > Whatever.
