Bug#1109052: bmake: autopkgtest regression: illegal argument to -j -- must be positive integer!

[Paul Gevers]

Hi,

On 13-07-2025 17:35, Andrej Shadura wrote:

This is, obviously, not going to work, as bmake doesn’t support *any* long 
(dash-dash) options, and does not support job servers at all. Which means the 
debhelper integration module has to filter out all long options out of 
MAKEFLAGS:

@@ -56,6 +56,10 @@ sub do_make {
         if ($ENV{MAKEFLAGS} =~ /^[^-]/) {
             $ENV{MAKEFLAGS} = "-$ENV{MAKEFLAGS}";
         }
+       my @makeflags = grep {
+           !/^--/
+       } split(' ', $ENV{MAKEFLAGS});
+       $ENV{MAKEFLAGS} = join(' ', @makeflags);
     }

Paul

I understand that users of bmake shouldn't (and wouldn't) pass long options to bmake, but stripping them out blindly (without warning) sounds like it could lead to surprises. I understand that these options come from toolchain things around bmake, so wouldn't it be smarter to specifically filter those out and/or emit a warning when you strip an unrecognized option?

OpenPGP_signature.asc
Description: OpenPGP digital signature