Hello NoisyCoil,

* NoisyCoil <[email protected]> [2026-02-25 01:51]:
> I gave a look at the changes but I'm not familiar at all with the codebase.
> Since I don't understand what I'm looking at, I'm afraid I can't help you
> with the sponsorship.

I did another non-vibe coded version of the patch with the minimal
changes that is easier to review. Find it here:

https://tg.st/u/0001-Use-fuse3.patch

> As for the use of generative AI, note that Debian doesn't have a
> policy yet on whether such contributions are acceptable, mostly (but
> not only) for copyright reasons.

I rewrote the patch by myself.

> Looking at the changes, most of them look simple enough
> that they are probably not even copyrightable, but the `afuse_utimens`
> function concerns me a bit.

If you look closely at it, it is just a copy of the already existing
function with an additional struct fuse_file_info *fi parameter being
ignored and struct utimbuf *buf replaced with const struct timespec
tv[2] in order to support timestamps with nanosecond granularity. The
one line that is replaced is taken straight of the libfuse3 examples
that ship with Debian:

-               retval = get_retval(utime(real_path, buf));
+               retval = get_retval(utimensat(AT_FDCWD, real_path, tv, 
AT_SYMLINK_NOFOLLOW));

The new patch reflects that minimal change better due to not duplicating
existing code and don't use ifdefs.

> If it came from somewhere, we should know to what extent it reproduces
> other code and add a copyright notice if needed.  Unfortunately, AIs
> being black boxes we can't really do that.

I hope I was able to address all of your concerns and you can sponsor
me, otherwise I'll ask other Debian maintainers and if noone will take
it, I just maintain it outside of Debian.

Cheers,
        Thomas

Reply via email to