Control: tags -1 + patch

In C23 (GCC 15 default), empty parameter lists `()` on function
declarations and function-pointer types now mean "no parameters" instead
of "unspecified parameters".  The xdvik source had several stale
declarations of this form that conflict with their correct prototypes:

  * squeeze/squeeze.c: `extern void exit()` conflicts with <stdlib.h>'s
    `exit(int)` (already included); remove the stale local declaration.
  * dvi-draw.c: likewise for `extern off_t lseek()` and
    `extern double pow()`.
  * gui/menu.h + gui/menu.c: the `Boolean (*cmp)()` function-pointer
    parameter of set_menu/set_menu_info is always passed one of the
    five callbacks declared in events.h (check_toggle, check_int, etc.)
    as `Boolean f(void *, const char *)`.  Spell out the correct type.
  * gui/sfDraw.c: `extern int SFchdir()` is redundant — sfPath.h
    (already included) provides `int SFchdir(const char *path)`.
  * gui/Panner.c: `extern Bool XmuDistinguishablePixels()` is called
    with four arguments; replace with `#include <X11/Xmu/StdCmap.h>`
    which has the correct prototype.
  * gui/sfDraw.h + gui/sfSelFile.c: `int (*SFfunc)()` is assigned
    and called with signature `int(char *, char **, struct stat *)`;
    spell out the correct type.

Thanks & Regards,
Azeez Syed

Attachment: xdvik-ja-1098134.debdiff
Description: Binary data

Reply via email to