tag 398626 +patch
thanks

On Wednesday 15 November 2006 08:55, Torsten Werner wrote:
> On 11/15/06, Sune Vuorela <[EMAIL PROTECTED]> wrote:
> > as far as I can see it is a bug in the postinst.
> >
> > Configure starts with calling the function fixperms and then it calls the
> > setup_apache function.
> >
> > in fixperms it tries to chown $configfile, but this fails because
> > $configfile is first created in the setup_apache function that is invoked
> > afterwards.
>
> Thanks, that is a real bug. Martin, can you fix it, please?


A quick patch to fix the issues with installing jwchat  -  and with removing 
after a manual disable of the apache module (or if install fails half way 
thru)

Another problem is that it automagically enables the site on upgrade/reinstall 
even if I as a sysadm have disabled it already. I have not a fix for this.

/Sune

/Sune
-- 
How can I reinstall a CPU?

You should never mount a program for getting access over the memory.
diff -u jwchat-1.0beta2/debian/postinst jwchat-1.0beta2/debian/postinst
--- jwchat-1.0beta2/debian/postinst
+++ jwchat-1.0beta2/debian/postinst
@@ -20,7 +20,6 @@
 	find $wwwdir -type d -exec chmod 0755 {} \;
 	find $wwwdir -type f -exec chmod 0644 {} \;
 	find $wwwdir -type f -exec chown nobody:nogroup {} \;
-	chown www-data:www-data $configfile
 }
 
 setup_apache()
@@ -30,6 +29,7 @@
 	sed -e "s|__ApacheServerName__|$apache_server_name|g" $configsource > \
 		$tempfile
 	ucf --three-way --debconf-ok $tempfile $configfile
+	chown www-data:www-data $configfile
 	if [ "$apache_server_name" != "none" ]; then
 		db_get jwchat/JabberAddress
 		jabber_address="$RET"
diff -u jwchat-1.0beta2/debian/postrm jwchat-1.0beta2/debian/postrm
--- jwchat-1.0beta2/debian/postrm
+++ jwchat-1.0beta2/debian/postrm
@@ -11,7 +11,7 @@
 case "$1" in
 	remove)
 
-	if [ -x /usr/sbin/a2dissite -a -x /etc/init.d/apache2 ]; then
+	if [ -x /usr/sbin/a2dissite -a -x /etc/init.d/apache2 -a -L /etc/apache2/sites-enabled/jwchat ]; then
 		a2dissite jwchat
 		invoke-rc.d apache2 force-reload
 	fi
diff -u jwchat-1.0beta2/debian/changelog jwchat-1.0beta2/debian/changelog
--- jwchat-1.0beta2/debian/changelog
+++ jwchat-1.0beta2/debian/changelog
@@ -1,3 +1,12 @@
+jwchat (1.0beta2-11.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * not meant as nmu - just template
+  * fix postinst to do stuff in correct order
+  * fix postrm to not do a unguarded a2dissite
+
+ -- Sune Vuorela <[EMAIL PROTECTED]>  Wed, 15 Nov 2006 09:18:30 +0100
+
 jwchat (1.0beta2-11) unstable; urgency=low
 
   * fix permission of config.js, closes #396255

Attachment: pgpkEyXG1gs0u.pgp
Description: PGP signature

Reply via email to