Hi Thomas Please fix your emails, they are really hard to read.
On Sun, Jun 29, 2025 at 05:55:30PM +0200, [email protected] wrote: > > Could someone see if openstack could finally fix that broken default? > There's as much as I know, no way to fix the default. That's why I ask to get OpenStack upstream to fix the default. Something like this, which also removes a lot of special cases. diff --git a/nova/virt/libvirt/blockinfo.py b/nova/virt/libvirt/blockinfo.py index e73cc4d..d12a916 100644 --- a/nova/virt/libvirt/blockinfo.py +++ b/nova/virt/libvirt/blockinfo.py @@ -247,26 +247,7 @@ def get_disk_bus_for_device_type(instance, # Otherwise pick a hypervisor default disk bus if virt_type in ("qemu", "kvm"): if device_type == "cdrom": - guestarch = libvirt_utils.get_arch(image_meta) - if guestarch in ( - obj_fields.Architecture.PPC, - obj_fields.Architecture.PPC64, - obj_fields.Architecture.PPCLE, - obj_fields.Architecture.PPC64LE, - obj_fields.Architecture.S390, - obj_fields.Architecture.S390X, - obj_fields.Architecture.AARCH64): - return "scsi" - machine_type = libvirt_utils.get_machine_type(image_meta) - # NOTE(lyarwood): We can't be any more explicit here as QEMU - # provides a version of the Q35 machine type per release. - # Additionally downstream distributions can also provide their own. - if machine_type and 'q35' in machine_type: - # NOTE(lyarwood): The Q35 machine type does not provide an IDE - # bus and as such we must use a SATA bus for cdroms. - return "sata" - else: - return "ide" + return "virtio" elif device_type == "disk": return "virtio" elif device_type == "floppy": Bastian -- I have never understood the female capacity to avoid a direct answer to any question. -- Spock, "This Side of Paradise", stardate 3417.3
