On Monday 01 September 2014 05:56 PM, Michael Biebl wrote:
>By quickly glancing over the package, I also noted that you ship a >systemd .service file named multipathd.service but the SysV init scripts >are named /etc/init.d/multipath-tools and >/etc/init.d/multipath-tools-boot (not quite sure why there are two). >
Yes. That's how they have been since beginning. Changing the init script now may break for users who may have been using it.
>systemd continues to start your SysV init scripts, but I assume this is >not wanted? Typically, the SysV init script and the systemd .service >file should have the same name, this way systemd will automatically pick >the native .service unit. >If you want to keep the upstream name for the .service, this is >absolutely file as well (and even encouraged), but you should make sure >the SysV init script is not run then. >There are two possible ways: Provide a symlink(alias) >/lib/systemd/system/<sysvinit_name>.service → >/lib/systemd/system/<upstream_service_file_name> >or mask the SysV init script by shipping a symlink pointing to /dev/null.
Okay.. I'll look into it.
Another issue: You install the native .service file but you aren't actually enabling it. We recommend to use dh-systemd for that.
Thanks. Will look into it too.
Since ./multipathd/multipathd.service also references a multipathd.socket unit, make sure this one is installed as well.
Yes. I'm installing them both.
If you have further questions, please don't hesitate to ask the pkg-systemd-maintainers mailing list.
In native init scripts, we did a lot of check before starting and shutting down the daemon. Things like checking the root device, or tiggering LVM Volume Group activitation. They were easily done in shell.
What would the systemd team recommend for it ? -- Ritesh Raj Sarraf | http://people.debian.org/~rrs Debian - The Universal Operating System -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/54046f17.6010...@debian.org