Natanael Copa writes ("Bug#465420: [PATCH] dpkg-1.14.16.6 does not compile on non-nls systems"): > Package: dpkg > Version: 1.14.16.6 > > dpkg fails to compile if there are no gettext and libintl.h even with > the --disable-nls compile flag. > > There are some nice defines in lib/dpkg.h that defines _() as gettext() > but unfortunally gettext() is used many places. The attatched patch > fixes the lib/dpkg.h header to only include libintl.h when ENABLE_NLS is > defined and it replaces gettext() with _() all places.
I think this patch should not be applied. AIUI there is a semantic difference between _() and gettext(), which is that _() is used to capture strings for translation. gettext is for other situations. So the arrangements for compiling without NLS should redefine gettext to the identity function, rather than _. > If you prefer the current style and mix gettext() and _() the please at > least add some dummy defines of gettext() in lib/dpkh.h (See > https://bugs.gentoo.org/attachment.cgi?id=143289 for example how this > can be done) That sounds better. Ian. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]