Your message dated Tue, 14 Apr 2009 09:11:14 +0200
with message-id <20090414071114.ga23...@rivendell>
and subject line Re: Bug#448667: dpkg-source resets SIGPIPE
has caused the Debian Bug report #448667,
regarding dpkg-source resets SIGPIPE
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
448667: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=448667
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dpkg
Version: 1.9.11
While checking something else I saw this in dpkg-source.pl:
$SIG{'PIPE'} = 'DEFAULT';
...
local $SIG{PIPE} = 'DEFAULT';
This appears to correspond to some of the following changelog entries:
dpkg (1.9.11) unstable; urgency=low
* Apply patch from Colin Watson: Closes: #89679
* Reset SIGPIPE to DEFAULT when forking gzip.
dpkg (1.9.8) unstable; urgency=low
* Reset SIGPIPE back to default, in dpkg-source. Closes: #98563.
I disagree with this and in my opinion this code should be removed.
All UNIX programs are entitled to assume that they start with signals
set to the default values (except SIGHUP and perhaps another exception
or two). Starting dpkg-source (or dpkg or any other unsuspecting
utility) with SIGPIPE ignored is simply wrong and if the program makes
extensive use of subprocesses and has good error handling, it is
liable to fail under those conditions.
If it is absolutely necessary to do something about this kind of bug,
dpkg-source should be changed to _fail_ if SIGPIPE is not set to
DEFAULT on startup. Fixing it up merely hides the problem and leaves
other programs vulnerable to mysterious failures.
Ian.
--- End Message ---
--- Begin Message ---
Version: 1.14.17
On Tue, 30 Oct 2007, Ian Jackson wrote:
> If it is absolutely necessary to do something about this kind of bug,
> dpkg-source should be changed to _fail_ if SIGPIPE is not set to
> DEFAULT on startup. Fixing it up merely hides the problem and leaves
> other programs vulnerable to mysterious failures.
Nowadays dpkg-source doesn't touch SIGPIPE at all, it simply ignores
SIGPIPE failures on read from from gunzip processes.
Cheers,
--
Raphaël Hertzog
Contribuez à Debian et gagnez un cahier de l'admin Debian Lenny :
http://www.ouaza.com/wp/2009/03/02/contribuer-a-debian-gagner-un-livre/
--- End Message ---
