On Sun, 07 Jun 2009, Neil Williams wrote: > The behaviour with DEB_VENDOR should match the behaviour with --vendor > and there should be some way of handling vendor names that include > spaces without needing to use quote marks when using the environment > variables or --vendor options.
That's plain stupid. Those options expect a vendor name and not a filename. You misused the interface by passing "emdebian-crush" instead of the vendor name. > It is inconsistent that the command line option works one way and the > environment variable works another way. It would be better to look only > for the matching filename and then use the value for the field from > that file. It's inconsistent, yes, but it's working correctly when you follow the rules. I can make it reject emdebian-crush if you want but my opinion is that being tolerant in what I accept is the right behaviour for me. > If the supplied argument matches the filename, why bother > cross-checking that with the Vendor: field inside the file? I would > have thought that the field can be the longer, descriptive title and > the filename can be a shortened version. It's not done on purpose, it's just an implementation detail and a consequence of the current Dpkg::Vendor API. > Currently, if the file specified originally has the Vendor changed from > the correct title "Emdebian Crush" to the corrupted form > "Emdebian-Crush", then dpkg-vendor works in the same way with both > forms. This change should not be necessary. Create the file "/etc/dpkg/origins/Emdebian Crush" and use "Emdebian Crush" as vendor name everywhere (DEB_VENDOR, --vendor) and it will work too. > What is the reason for the duplicate check? Implementation detail... in one case, get_current_vendor() is used (and returns the name inside the file instead of returning the original name) and in one case the vendor name is taken directly from the command line. Cheers, -- Raphaël Hertzog Contribuez à Debian et gagnez un cahier de l'admin Debian Lenny : http://www.ouaza.com/wp/2009/03/02/contribuer-a-debian-gagner-un-livre/ -- To UNSUBSCRIBE, email to debian-dpkg-bugs-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
