On Thu, 18 Jun 2009, Modestas Vainius wrote: > Hello, > > On 2009 m. May 30 d., Saturday 00:08:52 Modestas Vainius wrote: > > here is a bit improved new version of the patch. > > I wonder what's your general opinion about this patch. I'm asking because I > have to do a lot of changes to my tool to accomodate these dpkg-dev changes > and I happen to have some free time (and will) right now. I just want to know > if I wouldn't end up wasting my time... Maybe you can even convince me to > write missing docs (deb-symbols man page changes I guess?) if that sped up > patch inclusion into master...
I think it's mostly ok. I'm a bit surprized you integrated the "subst" logic right from the beginning. I would like to have the possibility to merge that part later so that I can ask more external review before integrating it. So if you can add some docs and make that part optional as a second patch on top of the first one, it will really help. I have planned to spend some time on dpkg on saturday so if you can get that done until then, I might be able to merge the first part this WE. As far as doc is concerned, it's dpkg-gensymbols's man page that should be updated and not deb-symbols (this one documents the format of the file inside the .deb). Cheers, -- Raphaël Hertzog Contribuez à Debian et gagnez un cahier de l'admin Debian Lenny : http://www.ouaza.com/wp/2009/03/02/contribuer-a-debian-gagner-un-livre/ -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
