On Mon, 03 Jan 2011, Bastian Blank wrote:
> It is a crafted file. It consists of two appended diffs.

Why not use two diffs instead?

> diff.gz is never hand-generated, the contents of debian/patches are. If
> they may not, you have to document it.

True.

> > > quilt and patch applies this patch without problems:
> > > | Applying patch upstream-21334:993458f6c5a0+21405:ae381a864b4f
> > > | patching file xen/arch/x86/mm/hap/p2m-ept.c
> > > | patching file xen/arch/x86/mm/hap/p2m-ept.c
> > And quilt refresh will get rid of that.
> 
> And it gets rid of many other things, the comments for example.

Which comments? quilt refresh keeps all the data before the first patch.

> > I don't know whether I'm going to accept this request. I'm rather enclined
> > to tag it wontfix. But I welcome supplementary feedback.
> 
> Okay, another nail in the cofin of the quilt source format. It looks
> like a mistake to even thought about using it.

I haven't taken any decision yet, but you're the first to complain about
this particular (mis-)feature so it can't be so annoying as you make it
sound like.

Or maybe I should turn it into a warning and not die.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Follow my Debian News ▶ http://RaphaelHertzog.com (English)
                      ▶ http://RaphaelHertzog.fr (Français)




--
To UNSUBSCRIBE, email to debian-dpkg-bugs-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to